Repository navigation
Conversation
`validate_source_bracket` read the child's horizontal extent one axis at a time through `ξnodes`/`ηnodes`, which are the separable-axis accessors and exist only for `LatitudeLongitudeGrid` and `RectilinearGrid`. A curvilinear grid indexes its coordinates jointly in `(i, j)`, so attaching an `Interpolated` boundary condition to such a child threw a `MethodError` once Oceananigans filled in the condition's location, dimension and side. Read the extent from the face coordinates of the boundary's own line instead. That is what the boundary condition samples, and keeping it to the line rather than the whole hull leaves a per-side source free to span only its own side, which the boundary strips rely on. No test built a model on a curvilinear child, which is why this went unnoticed; the new testset regularizes all four sides and still rejects a parent that covers only part of the child. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #798