Repository navigation
Conversation
Broadcasting a reshape of the device levels into `interior(pressure)` indexes device memory element by element on ReactantState, which Reactant refuses. The column is built on the host and moved with one `set!`, a single copy on every architecture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dkytezab
requested review from
glwagner and
xkykai
and removed request for
glwagner
October 23, 2026 20:45
dkytezab
marked this pull request as ready for review
October 23, 2026 20:45
xkykai
approved these changes
Oct 23, 2026
| @@ -139,10 +138,9 @@ end | |||
| # Pressure on a `PressureLevelGrid` is the level coordinate (Pa), constant in space and time | |||
| function pressure_level_field(grid, dataset, architecture) | |||
Collaborator
There was a problem hiding this comment.
is this function signature used anywhere else? if not should be ok to remove the architecture arg
glwagner
approved these changes
Oct 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #805. Draft.
pressure_level_fieldbuilds the level column on the host and fills the field with oneset!, instead of broadcasting areshapeof the device levels intointerior(pressure), which onReactantStatefalls back to element-wise indexing of device memory. On a GPU it is the same single copy as theon_architectureit replaces. Thearchitectureargument is now unused; I kept the signature.Test:
test/reactant/test_reactant.jl, the levels in every column onCPU()andReactantState(). Not yet run locally.🤖 Generated with Claude Code