Repository navigation
Conversation
Broadcasting between the `interior` views of the surface geopotential and the elevation indexes device memory element by element on ReactantState, which Reactant refuses. `set!` of the operation `Φˢ / g` computes it with a kernel on the field's architecture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
dkytezab
marked this pull request as ready for review
October 23, 2026 20:43
glwagner
approved these changes
Oct 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #806. Draft.
surface_elevation(grid::PressureLevelGrid)computesset!(elevation, Φˢᶠᶜ / g)instead ofinterior(elevation) .= interior(Φˢᶠᶜ) ./ g, which onReactantStatefalls back to element-wise indexing of device memory.set!of an operation launches one kernel on the field's architecture, so the CPU and GPU paths stay kernel-based and the result matches the CPU exactly onReactantState(the MWE in #806).Test:
test/test_pressure_level_grid.jl, the elevation of a surface rising from 100 to 400 m, on every test architecture. AReactantStatetest needs the pressure-level vertical to reach the device, which waits on CliMA/Oceananigans.jl#6007. Not yet run locally.🤖 Generated with Claude Code