Repository navigation
Conversation
`sum(interior(p₀))` is a generic reduction over a view of device memory, which on ReactantState reads element by element and errors. `sum(p₀)` reduces on the field's architecture and stays rank-local, so the `all_reduce` across ranks is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dkytezab
marked this pull request as ready for review
October 23, 2026 20:42
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
xkykai
approved these changes
Oct 23, 2026
glwagner
approved these changes
Oct 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #814. Draft.
mean_sea_level_pressurereduces withsum(p₀), Oceananigans's reduction on theField, instead ofsum(interior(p₀)), a generic reduction over a view of device memory that errors onReactantState.sum(p₀)returns a plain number on every architecture (Float32on aFloat32ReactantStategrid, the MWE in #814) and is rank-local like before, so theall_reduceacross ranks is unchanged.No new test: the function reads ERA5 single-level data, and the reduction on its own is what #814's MWE checks. Not yet run locally.
🤖 Generated with Claude Code