[19.0][MIG] base_multi_company by EmilioPascual · Pull Request #1009 · OCA/multi-company

EmilioPascual · 2026-06-03T14:37:31Z

Supersed of #889

I have re-run the migration from the current version 18. The old pull request was quite old and was causing numerous inconsistencies with the latest changes.
I have tried to preserve the commit authorship as far as possible.

@Vandan-Pandeji-SerpentCS, @astirpe, @weinni2000, @Murtaza-OSI, @chienandalu, @yajo please review

@moduon MT-14423

EmilioPascual · 2026-06-08T06:22:37Z

@OCA/intercompany-maintainers could you review and merge it, please? Thank you

OCA-git-bot · 2026-06-08T14:51:23Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

BhaveshHeliconia

LGTM!

BhaveshHeliconia · 2026-06-09T07:09:24Z

@EmilioPascual Please squash the commits as explained here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

EmilioPascual · 2026-06-09T10:49:03Z

@EmilioPascual Please squash the commits as explained here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

Done. Thanks for the review.

* Create new module to provide base multi company logic and mixin * Add deactivation by company mixin * Add company_id/ids handling * Add break after company is found Squashed commits: [854cc36] Increase test coverage [770bd71] Revert hook view create back to model init [40e803e] Fix apples and oranges [7a4dfb4] Use registry correctly [6e9f170] Switch company_id to computed & move company aliased view creation to post init hook [faa4fc9] Remove active functionality [fecfb59] Add explicit tests for active and inactive searches

* Revert "Revert hook view create back to model init" This reverts commit 770bd71. * [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log

Squashed commits: [4c17d04] auto_join company_ids

…ch domain on company_id/company_ids (+1 squashed commit) Squashed commits: [fe161fe] [ADD] setup.py

- Test if a company is set in inverse method (+1 squashed commit) Squashed commits: [d670f30] [FIX] fix init hooks as company_id is not stored anymore

* Add implementation instructions to ReadMe

[FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Bad branch version pushed before [FIX] Bad branch version pushed before [FIX] manifest Fix flake Flake8 on OCA tests

… are bound to some company

Currently translated at 88.9% (8 of 9 strings) Translation: multi-company-10.0/multi-company-10.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-10-0/multi-company-10-0-base_multi_company/pt/

Currently translated at 100.0% (4 of 4 strings) Translation: multi-company-18.0/multi-company-18.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-18-0/multi-company-18-0-base_multi_company/sl/

MT-14423 Co-authored-by: Vandan-SCS <73175574+Vandan-Pandeji-SerpentCS@users.noreply.github.com>

…CA#2)

When a record is created or modified via onchange, `record.company_ids[:1]` may be a virtual (unsaved) record whose `.id` is a `NewId`. Assigning that to the computed `company_id` field propagates the `NewId` into any downstream domain — most notably `_compute_same_vat_partner_id` in `res.partner`, which builds a search domain with `('company_id', 'in', [False, partner.company_id.id])` and triggers: psycopg2.ProgrammingError: can't adapt type 'NewId' MT-14423 MT-15070 @moduon

weinni2000

LGTM

rafaelbn · 2026-06-25T10:37:08Z

Please @OCA/intercompany-maintainers could you review and merge it, please? Thank you! ❤️

@EmilioPascual add your self as maintainter, we are maintaining this module 5 years

/ocabot migration base_multi_company

OCA-git-bot · 2026-06-25T10:37:24Z

Sorry @rafaelbn you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

rafaelbn · 2026-06-30T08:20:49Z

Hello ✋🏼 🤗

Please @gurneyalex @legalsylvain @LoisRForgeFlow , could you merge this one? Is validated, aproved... etc.

Running in prod 😄 ❤️

Others likes #1014 depends on this one

Thank you!
Regards,
Rafa

tristancatteeuw · 2026-07-02T09:46:43Z

Hello.
Just as a small note, I was testing this module in version 19, and it works fine, but is causing an error in odoo's data cleaning module, as it expects the company_id field to be stored.
ValueError: Cannot convert product.template.company_id to SQL because it is not stored

chienandalu · 2026-07-02T10:06:05Z

Thanks for the heads up @tristancatteeuw

@EmilioPascual is on holidays right now, so he won't be able to review the issue until he's back

rafaelbn · 2026-07-02T15:53:25Z

Hello @tristancatteeuw :

Did you tested in OCA's runboat?

Technical name: data_cleaning
License: Odoo Edición Enterprise v1.0

data_cleaning module is Enterprise so don't affects in this PR

Thank you!
Regards,
Rafael

LoisRForgeFlow

The migration looks good, however there are a few additional commits. In this one this new tests dragged my attention, see my comment below:

LoisRForgeFlow · 2026-07-06T14:01:27Z

+            uninstall_hook(self.env, rule_ref)
+
+        self.assertFalse(rule.active)
+        self.assertIn("company_ids", rule.domain_force)


After applying uninstall hook company_ids remains in the domain? does it make sense?

After applying uninstall hook company_ids remains in the domain? does it make sense?

Good catch, but this is intentional. The uninstall_hook is deprecated and its purpose is to deactivate the rule (active = False), not to restore the original domain. Since the rule is inactive, the domain_force content is irrelevant for security enforcement.

Keeping company_ids in the domain_force is a safety measure: if the module is reinstalled later, the post_init_hook will re-activate the rule with the correct domain. If we cleared the domain_force on uninstall, the rule would be re-activated with an empty/incorrect domain upon reinstall.

@EmilioPascual Thanks for the explanation. This would probably need some more discussion, I think is not the cleanest way to resolve it. However, I also think it is not the most valuable discussion as uninstallation of this module will be really infrequent, not to mention re-installation. So let's move forward as is to focus on more important details :)

LoisRForgeFlow · 2026-07-06T14:09:33Z

/ocabot migration base_multi_company

EmilioPascual · 2026-07-21T11:25:09Z

Hello. Just as a small note, I was testing this module in version 19, and it works fine, but is causing an error in odoo's data cleaning module, as it expects the company_id field to be stored. ValueError: Cannot convert product.template.company_id to SQL because it is not stored

Thanks for the report. This is a known limitation of the module's design: company_id is intentionally a non-stored computed field because its value is context-dependent (it changes based on the current user's companies). The actual stored field is company_ids (Many2many).

Modules that expect company_id to be stored in the database (like data_cleaning) will need to handle this. However, this behavior is not new in the 19.0 migration — it has been the same since the module was created. If you need company_id as a stored field in a specific model, you can add store=True with the appropriate compute/depends in your own module's inheritance.

LoisRForgeFlow · 2026-07-21T13:59:25Z

/ocabot merge nobump

OCA-git-bot · 2026-07-21T13:59:36Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-1009-by-LoisRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot · 2026-07-21T14:04:44Z

Congratulations, your PR was merged at c110ce7. Thanks a lot for contributing to OCA. ❤️

EmilioPascual force-pushed the 19.0-mig-base_multi_company branch from 9048459 to d6b759f Compare June 3, 2026 14:44

OCA-git-bot added series:19.0 mod:base_multi_company Module base_multi_company labels Jun 3, 2026

Shide approved these changes Jun 5, 2026

View reviewed changes

EmilioPascual force-pushed the 19.0-mig-base_multi_company branch from d6b759f to 5bb33cf Compare June 5, 2026 07:34

chienandalu approved these changes Jun 5, 2026

View reviewed changes

OCA-git-bot added the approved label Jun 5, 2026

OCA-git-bot added the ready to merge label Jun 8, 2026

BhaveshHeliconia approved these changes Jun 9, 2026

View reviewed changes

EmilioPascual force-pushed the 19.0-mig-base_multi_company branch from 5bb33cf to 2ce2349 Compare June 9, 2026 10:48

EmilioPascual mentioned this pull request Jun 19, 2026

[19.0][MIG] product_multi_company #1014

Merged

1 task done

EmilioPascual force-pushed the 19.0-mig-base_multi_company branch from 2ce2349 to 7f22851 Compare June 19, 2026 13:13

OCA-git-bot added the mod:partner_multi_company Module partner_multi_company label Jun 19, 2026

lasley and others added 13 commits June 19, 2026 15:16

10.0 base multi company lmi (OCA#1)

0033933

* Revert "Revert hook view create back to model init" This reverts commit 770bd71. * [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log

PR fixes (+1 squashed commit)

b5c44a7

Squashed commits: [4c17d04] auto_join company_ids

[FIX] base_multi_company: Allow child_of/parent_of operator into sear…

3461874

…ch domain on company_id/company_ids (+1 squashed commit) Squashed commits: [fe161fe] [ADD] setup.py

- Remove depends as company_id is not stored anymore

ea8966e

- Test if a company is set in inverse method (+1 squashed commit) Squashed commits: [d670f30] [FIX] fix init hooks as company_id is not stored anymore

OCA Transbot updated translations from Transifex

9657eeb

[IMP] base_multi_company: Improve ReadMe

f694bc8

* Add implementation instructions to ReadMe

[MIG] *_multi_company: OpenUpgrade migration scripts

1a6554f

[FIX] Insert in company_ids relation's table only ids of records that…

ca4d8e0

… are bound to some company

[UPD] Update base_multi_company.pot

b26270d

Translated using Weblate (Portuguese)

b02134f

Currently translated at 88.9% (8 of 9 strings) Translation: multi-company-10.0/multi-company-10.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-10-0/multi-company-10-0-base_multi_company/pt/

[MIG] base_multi_company: Migration to 11.0

f37950c

OCA-git-bot and others added 7 commits June 19, 2026 15:16

[BOT] post-merge updates

4d7b711

Added translation using Weblate (Slovenian)

7082c41

Translated using Weblate (Slovenian)

7a01a69

Currently translated at 100.0% (4 of 4 strings) Translation: multi-company-18.0/multi-company-18.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-18-0/multi-company-18-0-base_multi_company/sl/

[MIG] base_multi_company: Migration to 19.0

20839cf

MT-14423 Co-authored-by: Vandan-SCS <73175574+Vandan-Pandeji-SerpentCS@users.noreply.github.com>

[19.0][IMP] base_multi_company: fix access errors and add robustness (O…

640c383

…CA#2)

[IMP] base_multi_company: V19 unit test cases.

e1bf18a

EmilioPascual force-pushed the 19.0-mig-base_multi_company branch from 7f22851 to 0ad0d7e Compare June 19, 2026 13:17

OCA-git-bot removed the mod:partner_multi_company Module partner_multi_company label Jun 19, 2026

EmilioPascual mentioned this pull request Jun 19, 2026

[19.0][MIG]base_multi_company #889

Closed

weinni2000 approved these changes Jun 19, 2026

View reviewed changes

rafaelbn mentioned this pull request Jul 2, 2026

Migration to version 19.0 #882

Open

6 of 25 tasks

LoisRForgeFlow reviewed Jul 6, 2026

View reviewed changes

OCA-git-bot added this to the 19.0 milestone Jul 6, 2026

OCA-git-bot added the bot is merging ⏳ label Jul 21, 2026

OCA-git-bot merged commit 311b6b1 into OCA:19.0 Jul 21, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 21, 2026

yajo deleted the 19.0-mig-base_multi_company branch August 20, 2026 11:27

Uh oh!

Conversation

EmilioPascual commented Jun 3, 2026

Uh oh!

EmilioPascual commented Jun 8, 2026

Uh oh!

OCA-git-bot commented Jun 8, 2026

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Jun 9, 2026

Uh oh!

EmilioPascual commented Jun 9, 2026

Uh oh!

weinni2000 left a comment

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Jun 25, 2026

Uh oh!

OCA-git-bot commented Jun 25, 2026

Uh oh!

rafaelbn commented Jun 30, 2026

Uh oh!

tristancatteeuw commented Jul 2, 2026

Uh oh!

chienandalu commented Jul 2, 2026

Uh oh!

rafaelbn commented Jul 2, 2026

Uh oh!

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

LoisRForgeFlow Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

EmilioPascual Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

LoisRForgeFlow Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

LoisRForgeFlow commented Jul 6, 2026

Uh oh!

EmilioPascual commented Jul 21, 2026

Uh oh!

LoisRForgeFlow commented Jul 21, 2026

Uh oh!

OCA-git-bot commented Jul 21, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants