Skip to content

Memrchr removal rustify v9.2 - #16088

Closed
catenacyber wants to merge 4 commits into
OISF:mainfrom
catenacyber:memrchr-removal-rustify-v9.2
Closed

catenacyber wants to merge 4 commits into
OISF:mainfrom
catenacyber:memrchr-removal-rustify-v9.2

Conversation

@catenacyber

Copy link
Copy Markdown
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
None, should there be for a cleanup ?

Describe changes:

  • util: remove memrchr (and replace its only user by rust)

Alternative to #15772

#15921 rebased after MSRV bump

As its only usage got rustified
Like "1.1.1.1,2.2.2.2"

Or with more spaces like "1.1.1.1 , 2.2.2.2"
@codecov

codecov Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.37500% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.02%. Comparing base (acd9d3a) to head (f2abfac).
⚠️ Report is 150 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16088      +/-   ##
==========================================
- Coverage   83.05%   83.02%   -0.04%     
==========================================
  Files        1004     1003       -1     
  Lines      277359   277285      -74     
==========================================
- Hits       230370   230221     -149     
- Misses      46989    47064      +75     
Flag Coverage Δ
fuzzcorpus 61.53% <81.25%> (+<0.01%) ⬆️
livemode 18.42% <0.00%> (-0.18%) ⬇️
netns 22.85% <0.00%> (-0.06%) ⬇️
pcap 45.36% <0.00%> (-0.06%) ⬇️
suricata-verify 67.10% <79.68%> (-0.05%) ⬇️
unittests 58.51% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa

Copy link
Copy Markdown

Information: QA ran without warnings.

Pipeline = 33254

@catenacyber catenacyber added the needs rebase Needs rebase to main label Sep 15, 2026
@catenacyber

Copy link
Copy Markdown
Contributor Author

Rebased in #16222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs rebase Needs rebase to main

Development

Successfully merging this pull request may close these issues.

2 participants