Conversation
Treat bad link-header CRCs and impossible link lengths as recoverable errors and attempt to resynchronize. Also consume a response frame whose trusted length is too short for the required response headers, so later responses remain available. Ticket: 8980
Create a TX to carry the event if needed. Ticket: 8979
|
AI-generated review posted automatically by Suricata ai-review. Verdict: request changes
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16168 +/- ##
==========================================
+ Coverage 83.11% 83.13% +0.02%
==========================================
Files 1004 1004
Lines 277558 277577 +19
==========================================
+ Hits 230692 230767 +75
+ Misses 46866 46810 -56
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
catenacyber
reviewed
Sep 2, 2026
| } | ||
|
|
||
| /** | ||
| * \brief Set a directional event, allocating a transaction if necessary. |
Contributor
There was a problem hiding this comment.
Event is not directional
catenacyber
reviewed
Sep 2, 2026
| /** | ||
| * \brief Set a directional event, allocating a transaction if necessary. | ||
| */ | ||
| static void DNP3SetEventDirection(DNP3State *dnp3, bool request, uint8_t event) |
Contributor
There was a problem hiding this comment.
Why is this named DNP3SetEventDirection ?
Direction looks like a leftover
catenacyber
reviewed
Sep 2, 2026
catenacyber
reviewed
Sep 2, 2026
| STREAM_TOCLIENT, packet_bytes, sizeof(packet_bytes)); | ||
|
|
||
| FAIL_IF(r == 0); | ||
| FAIL_IF(r != 0); |
Contributor
There was a problem hiding this comment.
You could have moved this to a SV test ;-)
Member
Author
There was a problem hiding this comment.
Covered by tests/dnp3/issue-8980-dnp3-framing-recovery, don't really see the need to remove a UT. Though with all that setup its a bit more than a UT.
|
Information: QA ran without warnings. Pipeline = 33705 |
Member
Author
|
Replaced by #16170 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://redmine.openinfosecfoundation.org/issues/8979
Ticket: https://redmine.openinfosecfoundation.org/issues/8980
SV_BRANCH=OISF/suricata-verify#3347