pgsql: truly disable by default - v1 - #16175
Open
jufajardini wants to merge 1 commit into
Open
Conversation
While the pgsql parser is disabled if its setting is present in the yaml config file, it is actually enabled if truly defaulted, that is, if not present in the settings. Actually disable pgsql parsing and logging if not present in the suricata.yaml config. This implies that eve output also has to be explicitly enabled, now. Bug: OISF#8349
|
AI-generated review posted automatically by Suricata ai-review. Verdict: approve No high- or medium-severity findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16175 +/- ##
==========================================
- Coverage 83.14% 83.13% -0.01%
==========================================
Files 1004 1004
Lines 277579 277585 +6
==========================================
- Hits 230789 230769 -20
- Misses 46790 46816 +26
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WARNING:
Pipeline = 33736 |
victorjulien
reviewed
Sep 4, 2026
| stream-depth: 0 | ||
| # Maximum number of live PostgreSQL transactions per flow | ||
| # max-tx: 1024 | ||
| # stream-depth: 0 |
Member
There was a problem hiding this comment.
this indentation change looks off? Or is this a diff viewer artifact?
Contributor
Author
There was a problem hiding this comment.
No diff artifact, it is odd indeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the pgsql parser is disabled if its setting is present in the yaml config file, it is actually enabled if truly defaulted, that is, if not present in the settings.
Actually disable pgsql parsing and logging if not present in the suricata.yaml config.
Bug: #8349
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8349
Describe changes:
pgsql, truly making it disabled by defaultThis means that if the protocol isn't explicitly enabled for detection a pgsql rule will throw an error, and that logging has to be explicitly enabled, too.
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#3351