Conversation
EngineAnalysisFP(), CleanupFPAnalyzer(), and CleanupRuleAnalyzer() were writing to and closing the wrong FILE* pointers. Fast pattern output was written to rules_analysis.txt instead of rules_fast_pattern.txt, leaving the latter effectively empty. Restore the behavior from before c8615bc, which inadvertently swapped the pointers. Bug: OISF#9007
|
NOTE: This PR may contain new authors. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16180 +/- ##
==========================================
- Coverage 83.14% 83.12% -0.02%
==========================================
Files 1004 1004
Lines 277579 277581 +2
==========================================
- Hits 230789 230742 -47
- Misses 46790 46839 +49
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@victorjulien , are you able to find my CLA? (Previous PR: #16173.) |
Member
You're good. This:
Is based on a quick scan of your commit email address vs. previous commits. |
victorjulien
approved these changes
Sep 15, 2026
Merged
Member
|
Merged in #16219, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EngineAnalysisFP(), CleanupFPAnalyzer(), and CleanupRuleAnalyzer() were writing to and closing the wrong FILE* pointers. Fast pattern output was written to rules_analysis.txt instead of rules_fast_pattern.txt, leaving the latter effectively empty.
Restore the behavior from before c8615bc, which inadvertently swapped the pointers.
Bug: 9007
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/9007
Describe changes:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=