Repository navigation
TEDEFO-5157: allow a node to be shared by multiple business entities - #93
Merged
rouschr merged 1 commit intoSep 1, 2026
Merged
Conversation
The rule "Relationships between business entities and nodes are consistent" assumed a 1-to-1 relationship: the node referenced by a business entity's repeatsWithNodeId had to carry a matching businessEntityId back-reference. Since TEDEMD-547 a node (e.g. ND-Organization) can be shared by several business entities, which produced false positives. Drop the businessEntityId back-reference constraint so the rule only verifies that the referenced node exists. - Add tedefo-5157 feature with valid (two entities share a node) and invalid (entity references a non-existent node) test data. - Update tedefo-3224 invalid data: its node error relied on a businessEntityId mismatch on an existing node, which is no longer a violation; retarget it to a non-existent node so the rule is still exercised.
yfanti
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule "Relationships between business entities and nodes are consistent" assumed a 1-to-1 relationship: the node referenced by a business entity's repeatsWithNodeId had to carry a matching businessEntityId back-reference. Since TEDEMD-547 a node (e.g. ND-Organization) can be shared by several business entities, which produced false positives.
Drop the businessEntityId back-reference constraint so the rule only verifies that the referenced node exists.