make blackoilmodules gpu compatible - #6849
Merged
multitalentloes merged 6 commits intoFeb 25, 2026
Merged
Conversation
bska
added
the
manual:irrelevant
avoid new template argument in addStorage calls fix indentation only use __device__ where needed
Member
Author
|
Jenkins build this please |
Member
Author
|
Jenkins build this please |
Member
Author
|
Warnings produced by |
atgeirr
approved these changes
Feb 24, 2026
atgeirr
left a comment
atgeirr
left a comment
Member
There was a problem hiding this comment.
Good to go when the two issues are adressed, please merge when done and Jenkins is green again.
| using LhsEval = typename StorageType::value_type; | ||
|
|
||
| if constexpr (enableFullyImplicitThermal) { | ||
| FluidSystem fsys = intQuants.getFluidSystem(); |
Member
There was a problem hiding this comment.
Although it is as of now a tiny object, I think this should be a const ref in case the design changes later.
Member
Author
There was a problem hiding this comment.
Good catch, fixed here and in diffusionmodules where the same mistake was made once.
| * \brief Construct the energy intensive quantities for the fully implicit thermal module. | ||
| */ | ||
| BlackOilEnergyIntensiveQuantities(Evaluation rockInternalEnergy, | ||
| Evaluation totalThermalConductivity, |
Member
Author
|
Jenkins build this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial merge of the work for the GPU assembly in #6612