Use hybrid compositional flash by default - #7403
Merged
Merged
Conversation
GitPaean
added
the
manual:irrelevant
Member
Author
|
jenkins build this failure_report please |
Member
Author
|
This PR allows us to run through some cases without relaxing the flash tolerance, while it will be topic being revisited in the future development following new testing running. |
Member
Author
|
This PR will wait for the OPM/opm-common#5365. |
Member
Author
|
jenkins build this opm-common=5365 please https://ci.opm-project.org/job/opm-simulators-PR-builder/10635/ |
Member
Author
|
A few compositional related are merged, let us see how changing the default method will play out. No regression should be expected. |
Member
Author
|
jenkins build this please https://ci.opm-project.org/job/opm-simulators-PR-builder/10646/ |
Member
Author
|
As expected, there is no regression from the switching of the default flash method. I am marking it as ready for review now and inviting reviewers. |
GitPaean
marked this pull request as ready for review
September 17, 2026 11:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with OPM/opm-common#5245, newton solver will fall back to ssi if not converged.
it is also showing that the hybrid compositional flash solver produces some converged results that ssi failed to do so when working with #7306 .