(0.19.0) Changes for NumericalEarth coupling + gas exchange changes #411 - #399
Merged
Merged
Conversation
jagoosw
changed the title
jagoosw
changed the title
jagoosw
changed the title
jagoosw
added this pull request to stack #418
September 15, 2026 16:52
`K0` is defined in `OceanBioME.Models.CarbonChemistryModel`, not in the `GasExchangeModel` module the docstring lives in, so Documenter couldn't resolve the unqualified @ref and the docs build failed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TH7fhhztRhnmURhX3tWFMD
The MARBL reference tests passed a raw PolynomialParameterisation as the base_transfer_velocity, but surface_value dispatches through WindSpeedScaledTransferVelocities now. Wrap the k660 polynomial for the exchange construction and inline the formula for direct comparisons. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U3wSZLiTni7NKiLPcDGdVU
jagoosw
removed this pull request from stack #418
September 15, 2026 18:42
(0.19.0b) Improves gas exchange + adds MARBL's oxygen solubility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes we need for automatic NumericalEarth setup:
PARFromShortwavewhich has asurface_shortwave(that can be a number/field/function), and a PAR fractionsurface_valueto interpolate field time seriesProceeds NumericalEarth/NumericalEarth.jl#572
This PR is breaking in the gas exchange API as it moves the wind speed into the transfer velocity rather than being a top level property of the gas exchange. This is only breaking if you construct directly rather than using the co2 or oxygen convenience constructors (which I guess people probably don't).
Via #411: In the API the breaking changes are dropping first_virial_coefficient, cross_virial_coefficient, and air_pressure from CarbonDioxideConcentration, and solubility from the transfer velocity wrappers (they are now plain transfer velocities). The value of CO2 fluxes has also changed.