Repository navigation
chore(release): bump the minor version for breaking changes before 1.0 - #186
Merged
Merged
Conversation
Sturnus is not yet declared stable, and the two breaking changes in this round would otherwise jump it straight to 1.0.0. Before 1.0 a breaking change raises the minor version instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-please treats a breaking change before 1.0 as a major bump unless
bump-minor-pre-majoris set, so the pending release PR #185 currently proposes jumping from 0.16.0 straight to 1.0.0 on the strength of #183 and #184.What it does
Sets
bump-minor-pre-major: trueinrelease-please-config.json. Until Sturnus is deliberately declared stable, a breaking change raises the minor version: this round becomes 0.17.0, and the planned removal of the multi-guild machinery, itself breaking, becomes 0.18.0 rather than 2.0.0.What it deliberately does not do
It does not decide when 1.0 happens. That stays an explicit act (a
Release-As: 1.0.0footer, or removing this flag) rather than a side effect of whichever breaking change happens to land first.Checks
Configuration only;
jqparses the file. Release-please regenerates #185 after merge.