Skip to content

Scottaj bugfix/swift5/dates in path params - #24542

Closed
wing328 wants to merge 2 commits into
masterfrom
scottaj-bugfix/swift5/dates-in-path-params
Closed

Scottaj bugfix/swift5/dates in path params#24542
wing328 wants to merge 2 commits into
masterfrom
scottaj-bugfix/swift5/dates-in-path-params

Conversation

@wing328

@wing328 wing328 commented Jul 31, 2026

Copy link
Copy Markdown
Member

based on #23779

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes path parameter encoding in the swift5 generator so Dates and other types serialize correctly. Non-enum path params are now JSON-encoded before URL escaping to prevent malformed URLs.

  • Bug Fixes
    • Updated swift5/api.mustache to pass param.encodeToJSON() into APIHelper.mapValueToPathItem; enum handling is unchanged.
    • Regenerated Swift 5 Petstore samples across all libraries.

Written for commit 9efa7c5. Summary will update on new commits.

Review in cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants