Conversation
|
Hi @russlan23 Can you check if the issue persists in the There is a v5 release in the works and it would be best if the bugfix is available there. |
|
Both defects are still present on feature/v5-sec at e19d506. I ran the existing regression assertions in isolation against that commit’s schema JSON, RowResult dataclass, and hierarchical-rollup function: all four current-debt profile cases fail, and a lone revenue row is still rolled up as operating income. The same five cases pass against this PR’s current head, 28a2c9c. This was a dependency-free check of the affected definitions, not the full v5 provider suite. I have not retargeted the PR yet; the next step is validating the fix with the v5 package and its existing SEC tests before stacking it on #7525. |
28a2c9c to
345ce0f
Compare
|
Rebased onto In Docker with Python 3.11 and the SEC provider's frozen Some tests in that selection fetch public SEC/FASB taxonomy data, so the successful full run used network access. The separate |
Why?
Fixes #7634. SEC standardized statements were missing several current-debt XBRL spellings, and the hierarchical rollup could infer operating income from revenue alone, producing a misleading 100% operating margin.
What?
NotesAndLoansPayableandOtherShortTermBorrowingsto short-term debt across all statement profiles.OtherShortTermBorrowingswhere present.Impact
Current debt is classified consistently across industrial, financial, diversified, and insurance statements. Missing operating expenses no longer cause revenue to be presented as operating income.
Testing Done
pytest -q openbb_platform/providers/sec/tests/test_company_facts.py -k 'current_debt_tag_mappings or operating_income_not_rolled_up_from_single_child' --tb=short --disable-warnings(5 passed)pytest -q openbb_platform/providers/sec/tests/test_company_facts.py -k 'TestBLKIncomeStatement' --tb=short --disable-warnings(15 passed)git diff --checkjq emptyReviewer Notes
The operating-income guard is deliberately limited to
total_operating_income; other parent rows retain the existing generic rollup behavior.