Conversation
Collaborator
|
Hi, thanks for the PR and proposed fix. However, the implementation is flawed by conflating
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Fixes #7634. SEC standardized statements were missing several current-debt XBRL spellings, and the hierarchical rollup could infer operating income from revenue alone, producing a misleading 100% operating margin.
This supersedes #7637, which GitHub closed automatically when its temporary
feature/v5-secbase branch was deleted after #7525 merged. The same focused fix is now rebased onto the currentv5branch.What?
NotesAndLoansPayableandOtherShortTermBorrowingsto short-term debt across all statement profiles.OtherShortTermBorrowingswhere present.Impact
Current debt is classified consistently across industrial, financial, diversified, and insurance statements. Missing operating expenses no longer cause revenue to be presented as operating income.
Testing Done
pytest tests/test_company_facts.py -q— 139 passedpytest tests -m 'not integration' -o addopts='' --tb=short -q— 2,265 passedruff check openbb_sec/utils/statement_schema/_imputation.py tests/test_company_facts.pyruff format --check openbb_sec/utils/statement_schema/_imputation.py tests/test_company_facts.pygit diff --check upstream/v5...HEADThe full SEC test selection used the repository's frozen
uv.lockin Docker with Python 3.11. The separateintegration/suite was not run.Reviewer Notes
The operating-income guard is deliberately limited to
total_operating_income; other parent rows retain the existing generic rollup behavior.