Repository navigation
fix(context): honor compaction summary output reserve - #683
Open
treasuresyq wants to merge 1 commit into
Open
treasuresyq wants to merge 1 commit into
treasuresyq wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
summaryOutputReserveto the summary request so tail planning and the providermaxOutputTokensuse the same budget.This PR does not restore the forced
thinking: { enabled: false }override removed by #665. It fixes the separate summary-budget inconsistency described in #615.Why
The compactor already calculates
summaryOutputReserve, butsummarize()receivedinput.maxOutputTokens, which is normally undefined. Normal compaction therefore fell back to the fixed 4,000-token output cap while tail planning used a different reserve.Refs #615
Verification
npm run buildnode --test --test-force-exit --test-timeout 60000 dist/tests/context/compaction-engine.spec.js(19 passed)node --test --test-force-exit --test-timeout 60000 dist/tests/context/autoCompaction.spec.js(22 passed)node --test --test-force-exit --test-timeout 60000 dist/tests/agent/loop/context-cap.spec.js(10 passed)Tests ran with Node
v22.23.1. No real-provider truncation test was run.