Conversation
|
peter-lawrey
marked this pull request as draft
September 8, 2026 15:13
peter-lawrey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional allocation listener around
UnsafeMemoryallocation and free operations. Callbacks receive the timestamp, address, size and a per-thread reusable stack-trace container; the default no-op listener skips trace capture. Listeners must copy any trace data they retain beyond the callback.Add tests for listener installation/reset, callback parameters, zero-address freeing, callback exceptions and trace-container reuse. These hooks cover the instrumented
UnsafeMemorypaths.This remains a WIP draft. Review callback reentrancy, listener changes across threads, failure handling and trace-capture overhead, and resolve the recorded Windows failure. Reusing the container does not make stack capture allocation-free or establish whole-JVM native-memory coverage.
Validation: the diff and recorded review/check history were inspected at
7bcb3934eeea. No build, test or benchmark was rerun for this metadata edit. Recorded commit statuses: 1 failure, 8 success. Failures include Snapshot Windows (Chronicle Core).