Add an inspectable fault-injection reliability benchmark - #765
Open
PranavMishra28 wants to merge 2 commits into
Open
Add an inspectable fault-injection reliability benchmark#765PranavMishra28 wants to merge 2 commits into
PranavMishra28 wants to merge 2 commits into
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
Author
|
The implementation is complete and this is ready for maintainer review. RFC/context: #764; related reliability failures: #488, OpenHands/OpenHands#14260, and OpenHands/OpenHands#13578. @neubig, I would especially value your feedback on whether this benchmark core belongs here and how the first SWE-bench runtime adapter should plug into the shared evaluation runner. @simonrosenberg, I would value your review of the SDK event/dispatch boundary and the persist-before-inject contract. |
PranavMishra28
marked this pull request as ready for review
July 30, 2026 21:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reliability-evalCLI, an example scenario, and an SDK event callback bridgeARCHITECTURE.mdand the public contract inDESIGN.mdDesign boundary
The benchmark core is fully executable and tested. Infrastructure-specific operations remain explicit adapter capabilities (
restart_sandbox,drop_dispatch_response,sigkill_mid_tool_call,partition_network, andheal_network) because their concrete implementation depends on the selected runtime and its privileges. This keeps the graders and schedule portable while making every injected action inspectable.The SDK bridge runs persistence callbacks before observing an event for fault injection. This preserves the central persist-before-inject invariant and avoids depending on hidden model reasoning.
Evidence and validation
uv run pre-commit run --files ...uv run pytest tests/test_reliability.py tests/test_async_evaluation.py tests/test_iterative_resume.pymake builduv run pytest teststimeoutis not installed; those failures are unrelated to this changeEngagement and context