Skip to content

pp_rk: bump to latest fixes, extend osd.json - #103

Merged
henkwiedig merged 3 commits into
OpenIPC:masterfrom
henkwiedig:bump
Aug 7, 2026
Merged

henkwiedig merged 3 commits into
OpenIPC:masterfrom
henkwiedig:bump

Conversation

@henkwiedig

@henkwiedig henkwiedig commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Bump pp_rk to the latest fixes:

Extend osd.json with examples how to use the new temperature readings as commented out "---IconTplTextWidget" widgets.
User will have to manually enable theses as they are currently not generalizable and depend on hardware and RXMODE.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

pixelpilot: bump PixelPilot_rk revision and extend OSD examples

✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Bump PixelPilot_rk (pp_rk) git revision to latest upstream fixes.
• Update WiFi RSSI facts to include adapter scoping for telemetry.
• Add example OSD widgets for RF temperature and video codec icons.
Diagram

graph TD
  A["Buildroot package"] --> B["PixelPilot_rk"] --> C["osd.json layout"] --> D["OSD widgets"]
  B --> E[("Fact providers")]
  E --> D
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Move hardware-specific widgets to a separate sample file
  • ➕ Keeps default osd.json strictly generic across RXMODE/hardware
  • ➕ Makes enabling temperature widgets an explicit opt-in via file swap/copy
  • ➖ Adds another file/variant to package and documentation burden
  • ➖ Users must manage multiple OSD layouts
2. Add a formal enable/disable mechanism in config schema
  • ➕ Avoids using "---"-prefixed widget types as pseudo-comments
  • ➕ Allows shipping examples disabled without relying on parser behavior
  • ➖ Requires upstream PixelPilot_rk feature work and coordination
  • ➖ More invasive than a packaging/config-only change

Recommendation: Current approach is acceptable for a packaging PR: updating fact tags and adding clearly example-oriented widgets keeps changes localized. If these temperature widgets are expected to remain niche, consider moving them into a separate sample osd.json variant to reduce default layout noise and avoid reliance on "---" type prefixes.

Files changed (2) +68 / -3

Other (2) +68 / -3
osd.jsonExtend OSD layout with adapter-scoped RSSI and example telemetry widgets +67/-2

Extend OSD layout with adapter-scoped RSSI and example telemetry widgets

• Adds explicit WiFi adapter scoping to RSSI facts to avoid ambiguity. Introduces example IconTplTextWidget entries for RF temperature (wfbcli and os_mon.wifi.temperature) and an IconSelectorWidget to display the active video codec (H.264/H.265).

package/pixelpilot/files/osd.json

pixelpilot.mkBump PixelPilot_rk git revision +1/-1

Bump PixelPilot_rk git revision

• Updates PIXELPILOT_VERSION to a newer commit hash to pull in upstream fixes referenced in the PR description.

package/pixelpilot/pixelpilot.mk

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Aug 6, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Bonnet RSSI tags diverged ✓ Resolved 🐞 Bug ≡ Correctness
Description
The PR updates package/pixelpilot/files/osd.json to filter os_mon.wifi.rssi by adapter: "0",
but Bonnet builds override that file via rootfs overlay and still use an osd.json without the
adapter tag. This leaves Bonnet images on the old RSSI selection behavior while other images use the
new filtering, which can produce inconsistent or ambiguous RSSI selection on multi-adapter systems.
Code

package/pixelpilot/files/osd.json[26]

+                {"name": "os_mon.wifi.rssi", "tags": {"adapter": "0", "type": "rssi_a"}}
Evidence
Bonnet images include board/openipc/bonnet/overlay as a rootfs overlay, which provides its own
/etc/pixelpilot/osd.json. That overlay file still uses os_mon.wifi.rssi tags without the newly
added adapter: "0" filter, so the PR’s change to the packaged config won’t apply on Bonnet builds.

package/pixelpilot/files/osd.json[20-56]
board/openipc/bonnet/overlay/etc/pixelpilot/osd.json[20-57]
configs/openipc_bonnet_defconfig[12-14]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`package/pixelpilot/files/osd.json` was updated to add an `adapter: "0"` tag to `os_mon.wifi.rssi` facts, but the Bonnet image uses `board/openipc/bonnet/overlay/etc/pixelpilot/osd.json` (via `BR2_ROOTFS_OVERLAY`) which still has the old tag set. As a result, the Bonnet target will not benefit from the new adapter filtering and will behave differently than the default packaged configuration.
### Issue Context
- Bonnet defconfig includes `board/openipc/bonnet/overlay` in `BR2_ROOTFS_OVERLAY`, so `board/openipc/bonnet/overlay/etc/pixelpilot/osd.json` will be deployed to `/etc/pixelpilot/osd.json` on that target.
- That overlay file still defines the RSSI widgets without `adapter`.
### Fix Focus Areas
- Update the Bonnet overlay OSD config to match the packaged RSSI fact tags:
- configs/openipc_bonnet_defconfig[12-14]
- board/openipc/bonnet/overlay/etc/pixelpilot/osd.json[20-47]
- (Optional alternative) If you want a single source of truth, remove the Bonnet overlay copy and let the package-installed `/etc/pixelpilot/osd.json` be used:
- package/pixelpilot/pixelpilot.mk[25-35]
- package/pixelpilot/files/osd.json[20-56]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


To customize comments, go to the Qodo configuration screen, or learn more in the docs.

Qodo Logo

Comment thread package/pixelpilot/files/osd.json
@henkwiedig
henkwiedig merged commit e7cc4b0 into OpenIPC:master Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant