You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Extend osd.json with examples how to use the new temperature readings as commented out "---IconTplTextWidget" widgets.
User will have to manually enable theses as they are currently not generalizable and depend on hardware and RXMODE.
• Bump PixelPilot_rk (pp_rk) git revision to latest upstream fixes.
• Update WiFi RSSI facts to include adapter scoping for telemetry.
• Add example OSD widgets for RF temperature and video codec icons.
Diagram
graph TD
A["Buildroot package"] --> B["PixelPilot_rk"] --> C["osd.json layout"] --> D["OSD widgets"]
B --> E[("Fact providers")]
E --> D
Loading
High-Level Assessment
The following are alternative approaches to this PR:
1. Move hardware-specific widgets to a separate sample file
➕ Keeps default osd.json strictly generic across RXMODE/hardware
➕ Makes enabling temperature widgets an explicit opt-in via file swap/copy
➖ Adds another file/variant to package and documentation burden
➖ Users must manage multiple OSD layouts
2. Add a formal enable/disable mechanism in config schema
➕ Avoids using "---"-prefixed widget types as pseudo-comments
➕ Allows shipping examples disabled without relying on parser behavior
➖ Requires upstream PixelPilot_rk feature work and coordination
➖ More invasive than a packaging/config-only change
Recommendation: Current approach is acceptable for a packaging PR: updating fact tags and adding clearly example-oriented widgets keeps changes localized. If these temperature widgets are expected to remain niche, consider moving them into a separate sample osd.json variant to reduce default layout noise and avoid reliance on "---" type prefixes.
Files changed (2) +68 / -3
Other (2) +68 / -3
osd.jsonExtend OSD layout with adapter-scoped RSSI and example telemetry widgets+67/-2
Extend OSD layout with adapter-scoped RSSI and example telemetry widgets
• Adds explicit WiFi adapter scoping to RSSI facts to avoid ambiguity. Introduces example IconTplTextWidget entries for RF temperature (wfbcli and os_mon.wifi.temperature) and an IconSelectorWidget to display the active video codec (H.264/H.265).
The PR updates package/pixelpilot/files/osd.json to filter os_mon.wifi.rssi by adapter: "0",
but Bonnet builds override that file via rootfs overlay and still use an osd.json without the
adapter tag. This leaves Bonnet images on the old RSSI selection behavior while other images use the
new filtering, which can produce inconsistent or ambiguous RSSI selection on multi-adapter systems.
Bonnet images include board/openipc/bonnet/overlay as a rootfs overlay, which provides its own
/etc/pixelpilot/osd.json. That overlay file still uses os_mon.wifi.rssi tags without the newly
added adapter: "0" filter, so the PR’s change to the packaged config won’t apply on Bonnet builds.
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
`package/pixelpilot/files/osd.json` was updated to add an `adapter: "0"` tag to `os_mon.wifi.rssi` facts, but the Bonnet image uses `board/openipc/bonnet/overlay/etc/pixelpilot/osd.json` (via `BR2_ROOTFS_OVERLAY`) which still has the old tag set. As a result, the Bonnet target will not benefit from the new adapter filtering and will behave differently than the default packaged configuration.
### Issue Context
- Bonnet defconfig includes `board/openipc/bonnet/overlay` in `BR2_ROOTFS_OVERLAY`, so `board/openipc/bonnet/overlay/etc/pixelpilot/osd.json` will be deployed to `/etc/pixelpilot/osd.json` on that target.
- That overlay file still defines the RSSI widgets without `adapter`.
### Fix Focus Areas
- Update the Bonnet overlay OSD config to match the packaged RSSI fact tags:
- configs/openipc_bonnet_defconfig[12-14]
- board/openipc/bonnet/overlay/etc/pixelpilot/osd.json[20-47]
- (Optional alternative) If you want a single source of truth, remove the Bonnet overlay copy and let the package-installed `/etc/pixelpilot/osd.json` be used:
- package/pixelpilot/pixelpilot.mk[25-35]
- package/pixelpilot/files/osd.json[20-56]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump pp_rk to the latest fixes:
Extend osd.json with examples how to use the new temperature readings as commented out "---IconTplTextWidget" widgets.
User will have to manually enable theses as they are currently not generalizable and depend on hardware and RXMODE.