examples: bump smolrtsp-libevent pin to include the 400-on-parse-failure fix - #60
Merged
Merged
Conversation
Pull in the current smolrtsp-libevent `main`, which includes the interleaved-frame dispatch refactor (smolrtsp-libevent#2) and the `400 Bad Request` reply on parse failure (smolrtsp-libevent#3). The old pin (369b1a3) predates the interleaved-frame API the current integration relies on, so the example no longer built against it. Verified: the example builds against smolrtsp master, and live a malformed or oversized request now gets `RTSP/1.0 400 Bad Request` instead of a silently dropped connection; valid requests still get 200. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
smolrtsp-libeventpin inexamples/CMakeLists.txtfrom369b1a3tob0329b4(currentmain), pulling in:400 Bad Requestreply on parse failure (dispatcher: reply 400 Bad Request on unparseable requests smolrtsp-libevent#3).The old pin predates the interleaved-frame API (
smolrtsp_parse_interleaved_frame/SmolRTSP_InterleavedFrameStatus, insmolrtsp/util.h) that the current integration relies on, so the example no longer built against it.Verification
Built the example against this branch (smolrtsp master) + the bumped libevent and exercised it live:
OPTIONSRTSP/1.0 200 OKCSeq(non-numeric)RTSP/1.0 400 Bad RequestCSeqRTSP/1.0 400 Bad RequestRTSP/1.0 400 Bad RequestRTSP/1.0 400 Bad RequestPreviously the malformed/oversized cases were silently dropped (the client hung until timeout). ASan clean throughout.
Context
Completes the chain started by #59 (bounded RTSP parsing /
allocaDoS fix): the parser reliably returns a parseFailureon bad input, and the integration now surfaces that as a proper400.🤖 Generated with Claude Code