Fix CodeQL note-severity alerts: missing @Override annotations - #837
Merged
vharseko merged 1 commit intoAug 4, 2026
Merged
Conversation
Add the 57 missing @OverRide annotations reported by java/missing-override-annotation. The compiler verifies every one of them: it rejects the annotation on a method which does not override anything, so all 57 are confirmed overrides. Most of them are in TextHTTPAccessLogPublisher (18), the SNMP access control lists and tables (22) and the three PBKDF2 password storage schemes (12). In TextHTTPAccessLogPublisher the annotated methods are the bodies of the enumeration constants, written as a single line table under a "@Formatter:off" marker, so the annotation is added inline inside the body rather than above the constant, which would not compile and would break the alignment of the table.
maximthomas
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes all 57
java/missing-override-annotationalerts.The compiler is the check here: javac rejects
@Overrideon a method which does not override anything, so every one of the 57 annotations is a confirmed override, and the change cannot alter behaviour.Where they are
TextHTTPAccessLogPublisher— 18SNMPInetAddressAcl,SNMPUserAcl,DsTableEntryImpl,DsApplIfOpsEntryImpl,DsMIBImpl,SNMPMonitor) — 22OpenDJProvider,SubResourceCollection,SubResourceSingleton,ServiceDiscoveryMechanismConfigManager,WritabilityMode— 5One special case
In
TextHTTPAccessLogPublisherthe annotated methods are the bodies of the enumeration constants, written as a single line table under a// @formatter:offmarker:The annotation has to go inside the constant body — placing it above the constant does not compile — and it is kept inline so that the alignment of the 18 line table is preserved.
Testing
opendj-core8173 tests,opendj-config547,opendj-rest2ldap531,opendj-server3 — all passing.opendj-server-legacy(-Pprecommit), covering the annotated classes:PBKDF2PasswordStorageSchemeTestCase(39),PBKDF2HmacSHA256PasswordStorageSchemeTestCase(39),PBKDF2HmacSHA512PasswordStorageSchemeTestCase(39),AbstractTextAccessLogPublisherTest(27),SNMPSyncManagerV2AccessTest(12),DebugLogPublisherTest(6),SNMPTrapManagerTest(1) — 163 tests, all passing.