OLMIS-8298: Take the React spec bundling from dev-ui - #93
Merged
Merged
Conversation
The tasks that bundle and instrument the *.spec.jsx files were kept here to prove they work. They now ship with dev-ui, so this repository only needs the image that carries them.
|
kszymankiewicz-sd
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tasks that bundle and instrument the
*.spec.jsxfiles were kept here to prove they work. They now shipwith dev-ui, so this repository only needs the image that carries them.
Keeping the local copy is not an option once dev-ui has the task. The
require('./grunt/react-tests.js')inthe Gruntfile runs after
loadNpmTasks('/dev-ui'), so it would re-registertest:reactand shadow theshared one. The move would then change nothing here, and this copy does not have the
amd: falsefix thatstops lodash replacing the global underscore.
Merge this after the dev-ui image has been republished. CI should still report 1003 tests; 975 means it got
the image without the task, and the
.jsxcoverage is gone again.