fix(spp_user_roles,spp_area): follow base_user_role rename of role_ids to user_role_ids - #508
Merged
Merged
Conversation
…s to user_role_ids OCA/server-backend #428 (merged 2026-09-04) renamed the computed res.users.role_ids One2many to user_role_ids, in the model and in the form, search and list views of base_user_role. Two of our view inheritances anchored their xpath on the old name, so spp_user_roles failed to install against the current 19.0 head of base_user_role ("Element cannot be located in parent view") and took every module that depends on it down with it. Rename both anchors to user_role_ids and bump spp_user_roles to 19.0.2.0.2 and spp_area to 19.0.2.0.3.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #508 +/- ##
==========================================
+ Coverage 76.88% 76.92% +0.04%
==========================================
Files 703 735 +32
Lines 45732 47935 +2203
==========================================
+ Hits 35160 36874 +1714
- Misses 10572 11061 +489
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every CI build that rebuilds the OCA download layer has failed since Friday 2026-09-04:
OCA/server-backend #428 (merged 2026-09-04 14:18Z) renamed the computed
res.users.role_idsOne2many touser_role_idsinbase_user_role— model, compute method and the form/search/list views. Two of our view inheritances anchor their xpath on the old name:spp_user_roles/views/user.xml— replaces//field[@name='role_ids']inbase_user_role.view_res_users_tree_inheritwith our storedrole_ids_stored. This is the error above; becausespp_base_commondepends onspp_user_roles, it takes nearly every module down with it.spp_area/views/user.xml— inserts the center-areas group before//field[@name='role_ids']inbase_user_role.view_res_users_form_inherit. Fails the same way once the first one is fixed.This is not caused by any OpenSPP2 change.
19.0at df808ef (#478) passed CI Friday 06:57Z, before the OCA merge; the scheduled Full Test Suite on the same commit failed Saturday with this error. PRs that passed since (#479, #397) did so only because CI served the pre-rename OCA code from the GitHub Actions layer cache. Anything that invalidates that layer — a Dockerfile change (#507) or arequirements.txtchange (dependabot #502–#506) — downloads the current OCA head and fails.Change
user_role_ids.spp_user_roles19.0.2.0.1 → 19.0.2.0.2,spp_area19.0.2.0.2 → 19.0.2.0.3, withreadme/HISTORY.mdfragments.No data migration: the renamed field is a non-stored compute. Our
role_ids_storedfield and theset_groups_from_rolesoverride are untouched; the OCA head still exposesrole_line_ids,_get_enabled_rolesandset_groups_from_roleswith the same signatures.Compatibility note
After this lands, OpenSPP requires
base_user_roleat or after OCA/server-backend cc051ce6. Images are built from the19.0branch head of that repo, so any fresh build gets it. A deployment that pinned an olderserver-backendcheckout would need to move it forward. #507 would allow pinning explicitly; the pre-rename commit is 9513a363 if anyone needs to hold back temporarily.Follow-up (not in this PR)
role_ids_storedexists to work around the list-view display bug that OCA #428 fixes properly (the nativerole_idsMany2many was shadowing the OCA One2many). The workaround field may now be redundant; worth a separate look rather than widening this fix.Verification
prettierandruffpass on the changed files.README.rst/index.htmlare intentionally not regenerated locally; CI's pinned generator is the authority and its diff will be applied verbatim.