Conversation
69cd897 to
35fdfe2
Compare
35fdfe2 to
d50e64e
Compare
fortuna
left a comment
There was a problem hiding this comment.
I think it's good to upgrade the dependencies, but the explanation does not make sense to me. We build a static binary, why would there be any conflict?
Were you able to reproduce the bug? Does this fix it?
(Also, kind of crazy how many new libraries it's pulling)
|
Yeah, I'm not yet convinced this fixes the issue (it's still in draft) and I'm suspicious of how dramatic the changes it makes are. We would want to test something like this very carefully. The user found that compiling with By the error message, this unsafe reflection code in psiphon is also involved. |
|
It seems like they are hacking the TLS library. Perhaps we need to update the psiphon dependencies instead. The reflection is concerning. I hope they are not doing any function calls with reflection (field lookup is ok), because that would disable dead code removal and bloat any code we build. |
run
go get -u golang.org/x/cryptoin sdk and in /xThis is to fix the error
Someone was seeing this while trying to use mobileproxy in an android app. Due to a new field being added in crypto/tls Conn.ConnectionState