Repository navigation
GS/TC: Improve target selection on source lookup - #15089
Open
refractionpcsx2 wants to merge 1 commit into
Open
refractionpcsx2 wants to merge 1 commit into
refractionpcsx2 wants to merge 1 commit into
Conversation
refractionpcsx2
force-pushed
the
gs_shadowheartsnonsense
branch
from
November 14, 2026 22:24
e150a9a to
ed72f2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Improves the areas checked for matching targets during source lookup
Rationale behind Changes
Previously we were setting the start coordinates for the requested area to 0,0 for X and Y, but this caused a problem in some games where they would for example, set the TBP to 0x0 and then offset the rect by 448, which is technically looking at 0xe00, but because of our previous code, this would then pick the target at 0x0 and just break.
These changes are quite invasive in the source lookup behaviour and there is a small modification which may adjust software behaviour
(testing now), but this will improve Shadow Hearts Covenant effects during battles.Suggested Testing Steps
Try a whole load of games, notable ones which I broke during development were Hitman Contracts/Blood Money, Beyond Good and Evil, Ridge Racer V, Need for Speed Hot Pursuit 2, Project Snowblind and Minority Report, so check those for any problems, but also pick a random smattering of games. And of course, check Shadow Hearts Covenant.
Did you use AI to help find, test, or implement this issue or feature?
No