Repository navigation
fix(lint): unbreak the pre-commit gate — stray trailing blank lines in xai_stt.py - #213
Merged
Merged
Conversation
The pre-commit 'end-of-file-fixer' hook has been failing on main since #211: libraries/python/getpatter/providers/xai_stt.py ends with two extra blank lines. Because the CI gate runs 'pre-commit run --all-files', this reds the 'Pre-commit (lint + hygiene)' check on every open PR regardless of what that PR touches. Whitespace only — no behaviour change, no changelog entry.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis currently red on thePre-commit (lint + hygiene)check, and has been since feat: xAI (Grok) voice provider suite — STT, TTS, Realtime in both SDKs #211:libraries/python/getpatter/providers/xai_stt.pyends with two extra blank lines, which theend-of-file-fixerhook rejects.pre-commit run --all-files, so this fails on every open PR regardless of what that PR touches — it blocked feat(providers): Fish Audio voice suite — TTS (s2.1-pro / s2-pro) + ASR in both SDKs #212 (Fish Audio provider), which does not go near that file.Implementation
libraries/python/getpatter/providers/xai_stt.py. Whitespace only.pre-commit run --all-fileson a clean checkout ofmain+ this fix: all nine hooks pass.Breaking change?
No. Whitespace only — no behaviour change.
Test plan
pre-commit run --all-files→ all hooks pass (was:end-of-file-fixerfailed)Docs updates
N/A — whitespace-only fix, exempt from the changelog rule.