Skip to content

CAnimData.cpp module matching improvement#60

Merged
encounter merged 2 commits into
PrimeDecomp:mainfrom
ShulkMaster:CAnimData2
Jul 23, 2026
Merged

CAnimData.cpp module matching improvement#60
encounter merged 2 commits into
PrimeDecomp:mainfrom
ShulkMaster:CAnimData2

Conversation

@ShulkMaster

Copy link
Copy Markdown
Contributor
  • replacing manual epsilon checks with kyoto lib helper close_enough

@decomp-dev

decomp-dev Bot commented Jul 21, 2026

Copy link
Copy Markdown

Report for GM8E01_48 (438a29b - 258ae00)

No changes

Report for GM8E01_00 (438a29b - 258ae00)

📈 Matched code: 36.33% (+0.02%, +612 bytes)

✅ 3 new matches
Unit Item Bytes Before After
main/MetroidPrime/CAnimData CAnimData::SetParticleEffectState(const rstl::basic_string<char, rstl::char_traits<char>, rstl::rmemory_allocator>&, bool, CStateManager&) +7 96.51% 100.00%
main/MetroidPrime/CAnimData CAnimData::UpdateAdditiveAnims(float) +5 98.53% 100.00%
main/MetroidPrime/CAnimData CAnimData::AddAdditiveSegData(const CSegIdList&, CSegStatementSet&) const +4 97.62% 100.00%
📈 2 improvements in unmatched items
Unit Item Bytes Before After
main/MetroidPrime/CAnimData CAnimData::DoAdvance(float, bool&, CRandom16&, bool) +64 68.67% 72.97%
main/MetroidPrime/CAnimData CAnimData::AdvanceAdditiveAnims(float) +31 74.72% 76.79%

Report for GM8E01_01 (438a29b - 258ae00)

📈 Matched code: 35.06% (+0.02%, +612 bytes)

✅ 3 new matches
Unit Item Bytes Before After
main/MetroidPrime/CAnimData CAnimData::SetParticleEffectState(const rstl::basic_string<char, rstl::char_traits<char>, rstl::rmemory_allocator>&, bool, CStateManager&) +7 96.51% 100.00%
main/MetroidPrime/CAnimData CAnimData::UpdateAdditiveAnims(float) +5 98.53% 100.00%
main/MetroidPrime/CAnimData CAnimData::AddAdditiveSegData(const CSegIdList&, CSegStatementSet&) const +4 97.62% 100.00%
📈 2 improvements in unmatched items
Unit Item Bytes Before After
main/MetroidPrime/CAnimData CAnimData::DoAdvance(float, bool&, CRandom16&, bool) +64 68.67% 72.97%
main/MetroidPrime/CAnimData CAnimData::AdvanceAdditiveAnims(float) +31 74.72% 76.79%

@encounter encounter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@encounter
encounter merged commit d5f53ab into PrimeDecomp:main Jul 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants