Skip to content

chore(e2e): remove preloader-test third-party deps - #8930

Open
maiieul wants to merge 3 commits into
mainfrom
claude/preloader-test-dev-deps-673942
Open

chore(e2e): remove preloader-test third-party deps#8930
maiieul wants to merge 3 commits into
mainfrom
claude/preloader-test-dev-deps-673942

Conversation

@maiieul

@maiieul maiieul commented Aug 17, 2026

Copy link
Copy Markdown
Member

What is it?

  • Infra

Description

preloader-test was the only e2e app with its own deps, and installing them needs e2e/** in the pnpm workspace instead of e2e/*. The headless modal/collapsible they served were only rendered by TestImporter, and the Counter4 family already covers the same shape (nested imports + context + handlers). So this removes the vendored headless components and the three devDeps; the workspace can stay e2e/*.

Verified: pnpm i leaves the lockfile untouched, and the app's client + preview builds pass.

@maiieul
maiieul requested a review from a team as a code owner August 17, 2026 14:30
@changeset-bot

changeset-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 899ffc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maiieul maiieul self-assigned this Aug 17, 2026
@maiieul maiieul moved this to Waiting For Review in Qwik Development Aug 17, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8930

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8930

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8930

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8930

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8930

@qwik.dev/devtools

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/devtools@8930

commit: 899ffc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting For Review

Development

Successfully merging this pull request may close these issues.

1 participant