chore(e2e): remove preloader-test third-party deps - #8930
Open
maiieul wants to merge 3 commits into
Open
Conversation
|
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
@qwik.dev/devtools
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
preloader-test was the only e2e app with its own deps, and installing them needs
e2e/**in the pnpm workspace instead ofe2e/*. The headless modal/collapsible they served were only rendered by TestImporter, and the Counter4 family already covers the same shape (nested imports + context + handlers). So this removes the vendored headless components and the three devDeps; the workspace can staye2e/*.Verified:
pnpm ileaves the lockfile untouched, and the app's client + preview builds pass.