merge aomp-dev into amd-staging - #2516
Closed
z1-cciauto wants to merge 6 commits into
Closed
Conversation
The script had grown by accretion: one flat body of loops and inline
conditionals, mixed quoting styles, and lower-case locals that read the same as
the environment variables the run is configured with.
Adopt the shape run_composable-kernels.sh already uses in this directory, so the
two suite runners read alike:
- named functions in "function name {" form for the steps that stand on their
own -- the compiler cross-check, and the build-and-run of one benchmark,
- UpperCamelCase locals against ALLCAPS for the variables a caller may
override, which now tells the two apart at a glance,
- braced expansions and quoted paths throughout,
- a block comment per function saying why it exists, replacing the inline
remarks that had drifted from the code they described.
The benchmark loop keeps only what it is about: pick the model, take the
directories, run each, count the verdicts. The work that follows adds to this
shape rather than to the old one.
No behaviour change. Every message, log line, results.txt entry and exit status
is byte-identical; verified by running the old and the new script over nineteen
scenarios -- both models and each alone, an unknown and an empty model list, six
shapes of HECBENCH_LIST including a path, a trailing slash and a wildcard, a
LAUNCHER, a timeout, a failing clean, a missing checkout and a missing src --
and diffing their stdout, stderr and results.txt.
AI-assisted.
Two ways the file could mislead a reader, both of them older than the work that follows. A refusal exits before the results file is touched, so a missing checkout left the previous run's PASS lines and TOTAL block in place, with nothing to distinguish them from this run's. Invalidate the file at the start of the run, ahead of every refusal, rather than after the checks that precede it. tee reports a failed write on its own stderr and nowhere else, so a results file that could not be written - a read-only checkout, a full disk - produced a complete PASS report on the terminal, exit 0, and no file to read it back from. Truncate it once, before the first line is teed to it, and refuse the run when that does not work. AI-assisted.
The runner needed a checkout someone else had made, so it could not be the first thing run on a fresh machine: clone_test.sh had to go first, and forgetting it showed up as "HeCBench not found" rather than as a missing step. Clone it when it is not there. The clone lands in a staging directory and is moved into place only once git reports success, so an interrupted clone cannot leave a half-checkout behind that a later run would take for a good one. HECBENCH_CLONE=0 keeps the previous behaviour of requiring an existing checkout; HECBENCH_REPO and HECBENCH_BRANCH say what to clone. AI-assisted.
Add AOMP_PROJECT_SRC, AOMP_SPIRV_SRC, and AOMP_SRC to aomp_common_vars and use them throughout the build_* scripts instead of hardcoding $AOMP_REPOS/<name>. Defaults preserve the historical $AOMP_REPOS layout, so behavior is unchanged when the variables are unset. This lets a single environment override redirect one component's source (e.g. to a per-task git worktree) without relocating the shared checkout of every other component. The llvm-project monorepo root is read by eight build scripts (project, offload, openmp, llvm_runtimes_standalone, comgr, libdevice, hipcc, extras) and must move together for a staged build to stay consistent; the previously hardcoded SPIRV-LLVM-Translator source is now overridable too. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…t-provisioning-1-preparation [HeCBench] Dataset Provisioning [1/7]: Prepare run script
z1-cciauto
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
September 8, 2026 00:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.