build: configurable-arch controller manager image (unify arm64 + ppc64le) - #623
Open
yansun1996 wants to merge 3 commits into
Open
build: configurable-arch controller manager image (unify arm64 + ppc64le)#623yansun1996 wants to merge 3 commits into
yansun1996 wants to merge 3 commits into
Conversation
This was referenced Aug 4, 2026
Closed
Builds the controller/manager container for both amd64 and arm64, in a single multi-platform image. This allows control plane nodes running arm64/aarch64 CPUs to be able to manage clusters with AMD GPUs. Not changes: - Build host still has to be amd64/x86_64 - GPU node still has to be amd64/x86_64 - e2e still only tests amd64/x86_64 Benefits: - Heterogeneous/multi-arch clusters do not need dedicated amd64/x86_64 control plane nodes just to control AMD GPU scheduling. Resolves ROCm#331
Signed-off-by: Amulyam24 <amulmek1@in.ibm.com>
yansun1996
force-pushed
the
multiarch-controller-manager
branch
5 times, most recently
from
August 4, 2026 22:41
90156f6 to
3fd286f
Compare
…gurable Unify the arm64 (ROCm#549) and ppc64le (ROCm#565) multi-arch work into a single configurable build for both the controller manager and utils container images. docker-build and docker-build-utils run `$(CONTAINER_ENGINE) buildx build --platform "$(PLATFORM)"`, defaulting to PLATFORM=linux/amd64. A single-platform build auto-loads into the local image store. Set PLATFORM to a single platform (linux/arm64) or a comma-separated list; a multi-platform list must be pushed via a direct `buildx --push`. Works with docker buildx and podman 4.0+. buildx auto-populates TARGETOS/TARGETARCH per platform, driving the Go cross-compile, the kubectl download, and the utils container's oc/kubectl client download. Dockerfile.build gains qemu-user-static + libc6-arm64-cross for cross-arch runtime stages. bundle build is left as upstream (amd64). Adds a developer-guide section. Co-Authored-By: Claude <noreply@anthropic.com>
yansun1996
force-pushed
the
multiarch-controller-manager
branch
from
August 4, 2026 22:58
3fd286f to
d6bd900
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconciles the two open multi-arch PRs into a single, configurable build for the controller manager image, driven by one architecture variable (
ARCH, defaultamd64).This branch:
Dockerfile/Makefile/internal/utils_container/Dockerfileconflicts in favor of the ppc64le cross-compile approach.managerbinary selected by one ENV.Supersedes / consolidates:
What changed
Dockerfilecross-compiles onemanagerbinary viaGOOS=${TARGETOS} GOARCH=${TARGETARCH}and copies the single${TARGET}.TARGETARCH/TARGETOSdefault toamd64/linux, so a plaindocker build(no build-args) yields an amd64 image.managerbuilds one binary honoringGOOS/GOARCH;docker-buildtakesARCH ?= amd64and passes it through as--build-arg TARGETARCH=$(ARCH)(+--platform linux/$(ARCH)). A separatedocker-build-multiarchretains thebuildx --pushmulti-platform manifest path (PLATFORMS ?= linux/amd64,linux/arm64,linux/ppc64le).Test plan
Verified end-to-end with real
docker builds, inspecting the ELFe_machineof/usr/local/bin/managerinside each image:make docker-build(default)3e 00= x86-64make docker-build ARCH=arm64b7 00= aarch64ARCH=arm64produces an aarch64 manager binarymanagercross-compiles for amd64 / arm64 / ppc64le (go build)ARCHpyspelling)docker run --privileged --rm tonistiigi/binfmt --install)🤖 Generated with Claude Code