Repository navigation
Rework postprocess Job upgrade semantics - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Scope
postprocessJob.mode: hookthe default ownership model.post-install,post-upgradehooks withbefore-hook-creation,hook-succeededdeletion.postprocessJob.mode: managedas an explicit opt-out for environments that want a stable release-owned Job and accept delete/recreate responsibility on pod-template changes.Decision
I chose Helm hook ownership over generated-name or a separate one-shot template because it is the smallest chart-native change that avoids normal Helm patch attempts against immutable Kubernetes
Job.spec.templatefields. Generated names would create orphan/cleanup ambiguity in this public chart; a separate one-shot template would move ownership outside the chart without giving reviewers a default safe contract.Acceptance Criteria
Validation
PATH=/tmp/codex-renderfarm-tools/bin:$PATH make testmake smoke-localPATH=/tmp/codex-renderfarm-tools/bin:$PATH make lintPATH=/tmp/codex-renderfarm-tools/bin:$PATH make template >/tmp/renderfarm-template-aws.yamlPATH=/tmp/codex-renderfarm-tools/bin:$PATH make template-local >/tmp/renderfarm-template-local.yamlPATH=/tmp/codex-renderfarm-tools/bin:$PATH make template-minio >/tmp/renderfarm-template-minio.yamlPATH=/tmp/codex-renderfarm-tools/bin:$PATH make template-security >/tmp/renderfarm-template-security.yamlPATH=/tmp/codex-renderfarm-tools/bin:$PATH scripts/render-examples.shpython3 -m json.tool charts/render-worker/values.schema.json >/tmp/render-worker-values.schema.jsonbash -n scripts/chart-contract-tests.shgit diff --checkpython3 /Users/winnie/.codex/skills/autoreview/scripts/autoreview --mode localrender-examples.shvalidated default, local, local-minio, AWS GPU/SQS, and security manifests with kubeconform strict.Docs Impact
postprocessJob.modeand the hook/managed ownership tradeoff.Risk And Rollback
Risk is moderate but bounded: enabled postprocess Jobs now default to hook ownership instead of normal Helm release ownership. This intentionally changes upgrade behavior to avoid immutable Job pod-template patch failures. Roll back by reverting this PR, or set
postprocessJob.mode: managedin private values to preserve release-owned stable Job behavior.Safety Boundary
No deploy, release, live cluster migration, real cloud resource operation, production data access, sensitive credential use, paid API access, or destructive git operation was performed.