Repository navigation
Add first-class render examples validation target - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Closes #29.
make render-examplesas a first-class Makefile entry that invokesscripts/render-examples.sh.Acceptance Criteria
make render-examplesexists and runs the current rendered example validation script.Validation
Local validation with Helm
v3.18.6and kubeconformv0.8.0, installed under/tmp/codex-renderfarm-toolsafter verifying Darwin arm64 release checksums:make lintmake templatemake template-localmake template-miniomake template-securitymake render-examplesmake testmake smoke-localgit diff --checkpython3 /Users/winnie/.codex/skills/autoreview/scripts/autoreview --mode localmake render-examplesrendered default, local, local MinIO, AWS GPU/SQS, and security-hardening examples and kubeconform reported all manifests valid.Docs Impact
make render-examples.docs/development.mddocuments the Makefile wrapper.docs/evidence-map.mdincludes rendered example validation evidence.Risk / Rollback
Risk is low because this wraps an existing script and does not change chart runtime behavior, rendered manifests, values, CI, cloud resources, or deployment flow. Roll back by reverting this PR if the target name or command grouping is confusing.
Security / Operations Boundary
No release, tag, package publish, deploy, live Kubernetes cluster, AWS/EKS/SQS/S3/Karpenter/IAM/Secrets Manager operation, production values, credentials, or destructive git operation was performed.