Changed syntax seperator in JULIA_CPU_TARGET - #2991
Conversation
Regression Testing Results
Detailed regression test results.Regression test aromatics:Reference: Execution time (DD:HH:MM:SS): 00:00:00:52 aromatics Passed Core Comparison ✅Original model has 15 species. aromatics Failed Edge Comparison ❌Original model has 106 species. Non-identical thermo! ❌
thermo: Thermo group additivity estimation: group(Cs-(Cds-Cds)(Cds-Cds)(Cds-Cds)H) + group(Cds-Cds(Cds-Cds)(Cds-Cds)) + group(Cds-CdsCsH) + group(Cds-CdsCsH) + group(Cds-Cds(Cds-Cds)H) + group(Cds-Cds(Cds-Cds)H) + group(Cds-CdsCsH) + group(Cdd-CdsCds) + Estimated bicyclic component: polycyclic(s4_6_6_ane) - ring(Cyclohexane) - ring(Cyclohexane) + ring(1,4-Cyclohexadiene) + ring(124cyclohexatriene) Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Errors occurred during edge comparison
ERROR conda.cli.main_run:execute(148): `conda run python scripts/checkModels.py aromatics-edge stable_regression_results/aromatics/chemkin/chem_edge_annotated.inp stable_regression_results/aromatics/chemkin/species_edge_dictionary.txt test/regression/aromatics/chemkin/chem_edge_annotated.inp test/regression/aromatics/chemkin/species_edge_dictionary.txt` failed. (See above for error)
|
|
Thanks @calvinp0! I will go ahead and merge now |
Motivation or Problem
Currently, the compiling of Julia in the Docker build has not been working correctly and has only been compiling for
x86_64CPUs. Everything following the comma has been intepreted by Julia as features/flags withinx86_64, thus not compiling for the rest that were written.Issue can be seen here: https://github.com/ReactionMechanismGenerator/RMG-Py/actions/runs/28938667444/job/85869089871#step:5:9567
So, have changed the separator from
,to;due to the comma being used as flags/features within a target. So, for example you would write:In this instance,
clone_allwill compile for variants of that architecture. It overall would be better to compile for all variants but it would increase the time to build and the size of the image.Now, since this PR will properly update the compiling of Julia for CPUs, we will see an increase in build time and size of the image. However, it will be working as intended now.\
Here is a discussion on the Julia forum about the separators: https://discourse.julialang.org/t/understanding-julia-cpu-target/116774/5