refactor: remove obsolete FIFO queue infrastructure (OSIDB-5512)

[Elkasitu]

The FIFO queue routing (FIFORouter, CelerySettings, fifo.* queues, celery-fifo-1/2 docker services) is disabled in production and superseded by LockableTaskWithArgs exclusive locks and BZSyncManager.schedule() dedup logic.

Remove all FIFO-related code and configuration:

• CelerySettings class and FIFORouter class from config/celery.py
• fifo.* queue definitions and task_routes assignment
• celery-fifo-1 and celery-fifo-2 services from docker-compose.yml
• FIFO routing test from test_celery_routing.py
• Stale FIFO references in code comments

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: f22699d2-f68d-4620-ae51-eeec1ae24e76

📥 Commits

Reviewing files that changed from the base of the PR and between 89db770 and 7c3a573.

📒 Files selected for processing (5)

• config/celery.py
• docker-compose.yml
• osidb/sync_manager.py
• osidb/tests/test_celery_routing.py
• osidb/tests/test_sync_manager.py

💤 Files with no reviewable changes (2)

• docker-compose.yml
• config/celery.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (4)

• GitHub Check: detect-secrets
• GitHub Check: migrations
• GitHub Check: tests
• GitHub Check: schema

🧰 Additional context used

📓 Path-based instructions (2)

Injection prevention (prodsec-skills): SQL: parameterized queries only; no string concatenation Command: no shell=True, os.system, or backtick exec with user input LDAP/XPath: escape special characters in filters Path traversal: canonicaliz...

⚙️ CodeRabbit configuration file

Files:

• osidb/sync_manager.py
• osidb/tests/test_sync_manager.py
• osidb/tests/test_celery_routing.py

Python security (prodsec-skills): No pickle.loads, marshal.load, shelve.open on untrusted data (RCE) No eval, exec, compile on non-literal input; use ast.literal_eval No yaml.load without SafeLoader; require yaml.safe_load subprocess: list...

⚙️ CodeRabbit configuration file

Files:

• osidb/sync_manager.py
• osidb/tests/test_sync_manager.py
• osidb/tests/test_celery_routing.py

🔇 Additional comments (3)

osidb/sync_manager.py (1)

848-853: LGTM!

osidb/tests/test_celery_routing.py (1)

7-8: LGTM!

osidb/tests/test_sync_manager.py (1)

385-388: LGTM!

---

📝 Summary

Summary by CodeRabbit

• Changes

  • Simplified background task processing to use the default and collectors queues.
  • Removed dedicated FIFO worker services and FIFO task routing.
  • Updated Jira synchronization recovery behavior to rely on periodic rescheduling after lock contention.

• Tests

  • Updated routing and synchronization test documentation to reflect the revised processing behavior.
  • Removed coverage for FIFO queue routing.

Walkthrough

The change removes configurable FIFO Celery routing and dedicated FIFO workers. It updates lock-contention documentation and removes the FIFO routing test.

Changes

Celery FIFO removal

Layer / File(s)	Summary
Remove FIFO routing and workers config/celery.py, docker-compose.yml	Removes CelerySettings, FIFORouter, generated FIFO queues, FIFO task routes, and the two dedicated FIFO worker services.
Update sync recovery documentation osidb/sync_manager.py, osidb/tests/test_celery_routing.py, osidb/tests/test_sync_manager.py	Documents dropped lock-contention retries and periodic recovery through MAX_RUN_LENGTH. Removes the FIFO routing test and updates routing documentation.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 7c3a5

This change removes obsolete FIFO Celery routing and worker configuration while aligning lock-contention documentation and tests with the existing recovery behavior. No concrete merge-blocking risk remains.

Suggested reviewers: alejandrominaya

🚥 Pre-merge checks | ✅ 9 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Ai-Attribution	⚠️ Warning	The pull-request commit explicitly identifies Claude Sonnet 4.5 and uses Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>. The custom check requires Red Hat Assisted-by or Generated-by …	Amend the commit message. Remove Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> and add an approved trailer, for example Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>.

✅ Passed checks (9 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description directly summarizes the removal of FIFO routing code, services, tests, and stale references.
Title check	✅ Passed	The title clearly and concisely describes the removal of obsolete FIFO queue infrastructure.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets	✅ Passed	PASS: The pull request adds no hardcoded secrets. The added lines are comments and routing-related documentation only. Secret-like values in docker-compose.yml, including PGPASSWORD: passw0rd and `P…
No-Weak-Crypto	✅ Passed	PASS. The pull request only removes FIFO Celery routing, Docker services, a routing test, and updates comments. The added lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography…
No-Injection-Vectors	✅ Passed	The pull request introduces no listed injection vector. The executable changes remove FIFO classes, queues, services, and a test. The only additions are comments and test documentation. Added-line sca…
Container-Privileges	✅ Passed	PASS. The pull request does not add container privilege settings. The docker-compose.yml diff only removes the celery-fifo-1 and celery-fifo-2 services. No changed file adds privileged, host n…
No-Sensitive-Data-In-Logs	✅ Passed	PASS. The committed PR diff adds no logging calls, output configuration, or sensitive-data values. The only added lines are comments and test documentation. Existing `logger.exception("Failed to confi…

Full details: Ai-Attribution

Explanation

The pull-request commit explicitly identifies Claude Sonnet 4.5 and uses Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>. The custom check requires Red Hat Assisted-by or Generated-by attribution and flags Co-Authored-By for AI tools.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-fifo-infrastructure

---

_{Comment @coderabbitai help to get the list of available commands.}