Skip to content

fix(pulseaudio,pipewire): build on targets without 64-bit atomics#1283

Open
roderickvd wants to merge 1 commit into
masterfrom
fix/32bit-atomic-u64
Open

fix(pulseaudio,pipewire): build on targets without 64-bit atomics#1283
roderickvd wants to merge 1 commit into
masterfrom
fix/32bit-atomic-u64

Conversation

@roderickvd

Copy link
Copy Markdown
Member

PulseAudio's latency tracking stores two microsecond counters in AtomicU64, which doesn't exist in std on exotic or legacy targets without native 64-bit atomics. This PR adds fallback to portable-atomic on such targets.

PipeWire hid the same error through its last_quantum field, but we can narrow that to u32 without any problem or pulling in another dependency.

Closes #1277

@roderickvd

Copy link
Copy Markdown
Member Author

@sandreas

@sandreas

Copy link
Copy Markdown

Awesome thank you, try to provide feedback tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cpal fails to build for 32bit systems

2 participants