Skip to content

🛡️ Sentinel: isSafeTabUrlにおけるプロトコル相対・パス相対URL判定バイパスの修正 - #1726

Open
RyutaKojima wants to merge 1 commit into
masterfrom
fix/tab-url-validation-bypass-553083490302776033
Open

RyutaKojima wants to merge 1 commit into
masterfrom
fix/tab-url-validation-bypass-553083490302776033

Conversation

@RyutaKojima

Copy link
Copy Markdown
Owner

🛡️ Sentinel セキュリティ修正:

🚨 深刻度: MEDIUM
💡 脆弱性: chromeTabs.tsのisSafeTabUrlにおいて、前後の空白除去およびプロトコル相対URL(//)やパス相対URL(/, \)の明示的拒否が不足していたため、new URL(url, 'chrome-extension://dummy/')の解釈時にchrome-extension:プロトコルへ解決され、安全なプロトコルとして誤判定される可能性がありました。
🎯 影響: タブ作成APIに対して意図しないURL解釈やバイパスが発生するリスクがありました。
🔧 修正: isSafeTabUrlに入力URLのトリム処理を追加し、//・/・\で始まる相対URLを明示的に判定失敗(false)とする検証を追加しました。
✅ 検証: yarn test(単体テスト)および yarn lint:all(TypeScript・ESLint・Stylelint)を通過することを確認しました。


PR created automatically by Jules for task 553083490302776033 started by @RyutaKojima

プロトコル相対URLやパス相対URLがnew URL(url, base)によって
chrome-extension:プロトコルへ解決され、安全なURLとして誤判定される問題に対処。

Co-authored-by: RyutaKojima <12064805+RyutaKojima@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant