Modification of the FlashFinder algorithm by CarlosNeutrino · Pull Request #925 · SBNSoftware/sbndcode

CarlosNeutrino · 2026-03-27T17:32:39Z

Description

This PR includes small changes in the FlashFinder algorithm
It includes the possibility of creating a shortened OpFlash when a flash candidate occurs before an already defined OpFlash
The time difference between the shortened OpFlash and the later one has to be at least of 0.5μs
The time-width of the flashes is saved as an attribute to the recob::OpFlash class. Its value will be 4μs for non-shortened flash and a smaller value for the newly added flashes
The modules that are affected are reco1:opflashtpc0:SBNDFlashFinder and reco1:opflashtpc1:SBNDFlashFinder
Details and validation plots can be found in the linked docdb

Link(s) to docdb describing changes (optional)

Link of the docdb describing the changes: docdb-46414

Relevant PR links (optional)

This PR does not require merging another PR before

Development

This PR raises this different issue on the OptT0 calculation: Issue-638. The OptT0 calculation needs to take into account the possibility that a flash might be shortened (its width can be less than 8μs).

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
Linked any relevant issues under Developement
Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
Does this affect the standard workflow?
Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

…eractions happening a time >8us before a different bigger flash

…der algorithm creates shortened flashes for some interactions that were vetoed before

Copilot

Pull request overview

This PR updates the SBND SimpleFlash flash-finding configuration and algorithm to allow creation of a shortened OpFlash when a new flash candidate starts before (and would overlap with) an already-claimed OpFlash, while propagating the shortened integration window into the produced flash time-width (LiteOpFlash_t::time_err → recob::OpFlash).

Changes:

Add new FHiCL configuration parameters to control “repeated/shortened flash” creation thresholds and timing constraints.
Extend SimpleFlashAlgo to optionally shorten a candidate flash’s integration window when it precedes an existing flash and meets PE/timing requirements.
Add extensive inline comments/debug prints describing configuration, vetoing, and flash construction steps.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File	Description
`sbndcode/OpDetReco/OpFlash/job/sbnd_flashalgo.fcl`	Adds new tunable parameters for repeated/shortened flash behavior.
`sbndcode/OpDetReco/OpFlash/FlashFinder/SimpleFlashAlgo.h`	Adds new configuration-backed member variables for repeated/shortened flash logic.
`sbndcode/OpDetReco/OpFlash/FlashFinder/SimpleFlashAlgo.cxx`	Implements shortened-flash selection logic and additional configuration validation and debug/commentary.

Comments suppressed due to low confidence (2)

sbndcode/OpDetReco/OpFlash/FlashFinder/SimpleFlashAlgo.cxx:410

The loop for(size_t opch=0; opch<max_ch; ++opch) skips the last channel (max_ch), but pe_v is sized max_ch+1. This leaves the last channel’s PE potentially negative/unclamped. Iterate up to and including max_ch (or opch < pe_v.size()).

            // Set negative PE to 0
            // Loop over OpChannels
            for(size_t opch=0; opch<max_ch; ++opch) {
                // Skip unused channels
                if(_opch_to_index_v[opch]<0) continue;

                //pe_v[opch] -= _pe_baseline_v[_opch_to_index_v[opch]];

                if(pe_v[opch]<0) pe_v[opch]=0;

sbndcode/OpDetReco/OpFlash/FlashFinder/SimpleFlashAlgo.cxx:350

Typo in debug output string: "does not interfare" should be "does not interfere".

                if(_debug) {
                    std::cout << "Flash @ " << min_time + used_period.first * _time_res
                    << " => " << min_time + (used_period.first + used_period.second) * _time_res
                    << " does not interfare with THIS flash @ " << min_time + start_time * _time_res
                    << " => " << min_time + (start_time + integral_ctr) * _time_res << std::endl;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

asanchezcastillo

Overall the changes look good to me. Thanks for having this done, it's a great improvement to the algorithm! I just left a few minor comments, once they're addressed PR can be approved!

…il truncation, added units to the comments, eliminated default value in configuration parameters

fjnicolas

Hi @CarlosNeutrino, thank you so much for the PR! This is a very nice improvement over the existing code (and thank you so much for adding all the comments to the existing codes, it improved a lot the readability for future contributors!).

I left three minor comments that could help saving some computing time, otherwise, happy to approve!

…s before the loop so the calculations are not repeated

aantonakis · 2026-07-10T23:50:28Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_21_00

FNALbuild · 2026-07-11T00:16:15Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-07-11T00:26:30Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-07-11T00:31:15Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-07-11T00:42:30Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

aantonakis · 2026-07-11T01:25:07Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_22_00 SBNSoftware/sbn*@SBN_SUITE_v10_20_05

FNALbuild · 2026-07-11T01:38:57Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-07-11T01:48:36Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-07-11T01:49:52Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-07-11T02:03:33Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

aantonakis · 2026-07-11T02:32:44Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_21_00 SBNSoftware/sbn*@SBN_SUITE_v10_20_05

FNALbuild · 2026-07-11T02:46:45Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-07-11T02:49:08Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-07-11T02:54:21Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-07-11T02:56:24Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

aantonakis · 2026-07-11T03:19:14Z

trigger build LArSoft/lardataalg@v10_02_01 LArSoft/lar*@LARSOFT_SUITE_v10_21_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_20_05

FNALbuild · 2026-07-11T03:32:18Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-07-11T03:41:59Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-07-11T03:43:02Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-07-11T03:52:43Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

aantonakis · 2026-07-11T04:18:17Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_21_00 LArSoft/lardataalg@v10_02_01 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_20_05

FNALbuild · 2026-07-11T04:32:25Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-07-11T04:35:08Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-07-11T04:41:33Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-07-11T04:44:44Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

Carlos Martin Morales added 3 commits March 27, 2026 04:49

New flash finder algorithm to create new shortened OpFlashes from int…

354cce2

…eractions happening a time >8us before a different bigger flash

Eliminated comments from older versions of the code. The new FlashFin…

c21311b

…der algorithm creates shortened flashes for some interactions that were vetoed before

Changed the configuration so debug printouts are not shown

d9007ee

CarlosNeutrino requested review from asanchezcastillo and fjnicolas March 27, 2026 17:32

CarlosNeutrino self-assigned this Mar 27, 2026

CarlosNeutrino added the reco1/reco2 Reconstruction label Mar 27, 2026

CarlosNeutrino changed the title ~~Optimization of the FlashFinder algorithm~~ Modification of the FlashFinder algorithm Apr 6, 2026

CarlosNeutrino marked this pull request as ready for review April 7, 2026 14:22

Copilot AI review requested due to automatic review settings April 7, 2026 14:22

Copilot started reviewing on behalf of CarlosNeutrino April 7, 2026 14:23 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

asanchezcastillo reviewed Jun 2, 2026

View reviewed changes

Addressing the comments on the revision of the code: fix multimap, ce…

f311b39

…il truncation, added units to the comments, eliminated default value in configuration parameters

fjnicolas approved these changes Jun 29, 2026

View reviewed changes

Comment thread sbndcode/OpDetReco/OpFlash/FlashFinder/SimpleFlashAlgo.cxx Outdated

Comment thread sbndcode/OpDetReco/OpFlash/FlashFinder/SimpleFlashAlgo.cxx Outdated

Comment thread sbndcode/OpDetReco/OpFlash/FlashFinder/SimpleFlashAlgo.cxx Outdated

Addressing the comments of the pull request: define constant variable…

7c428f5

…s before the loop so the calculations are not repeated

asanchezcastillo approved these changes Jul 1, 2026

View reviewed changes

Uh oh!

Conversation

CarlosNeutrino commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Link(s) to docdb describing changes (optional)

Relevant PR links (optional)

Development

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asanchezcastillo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fjnicolas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aantonakis commented Jul 10, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

aantonakis commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

aantonakis commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

aantonakis commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

FNALbuild commented Jul 11, 2026

Uh oh!

aantonakis commented Jul 11, 2026

Uh oh!

CarlosNeutrino commented Mar 27, 2026 •

edited

Loading