Add portfolio summary page#56
Open
haneslinger wants to merge 12 commits into
Open
Conversation
…ry-merge # Conflicts: # cspell.json # package.json # pnpm-lock.yaml # src/app/modules/organizations/settings/salesforce-building-integration/salesforce-building-integration.component.ts
- Resolve merge conflicts with main (cspell.json, package.json,
pnpm-lock.yaml, salesforce-building-integration component) by keeping
main's newer Salesforce Building Integration implementation (BB
Salesforce support, barrel imports) under the PR's renamed path.
- Convert new API/component imports to the @seed/api and MaterialImports
barrels per project convention; register goal and salesforce-portfolio
in the @seed/api barrel index.
- Fix missing salesforce-login/salesforce-portfolio-integration .scss
files referenced by styleUrl (never committed) by dropping the
styleUrl instead.
- Add full Transloco translation coverage for all new UI strings across
the portfolio summary, configure-goals, add-cycle,
salesforce-portfolio-integration and salesforce-login templates.
- Fix several crashes found via live testing against a real backend:
- ConfigureGoalsDialogComponent.save() threw when Salesforce
integration was not enabled / no partner was selected.
- AddCycleDialogComponent.submit() threw when no annual report was
selected (Salesforce not enabled).
- PortfolioSummaryComponent.createChart() threw when a goal had no
weighted EUI data yet.
- PortfolioSummaryComponent.openAddCycle() threw because cycle_goals
was never initialized/fetched.
- Removed a stray {{ chart }} interpolation inside the results canvas
that rendered "[object Object]".
- Add GoalService.getCycleGoals() and call it when selecting/updating a
goal so previously created cycle goals load after a refresh (the
Goal API response never embeds cycle_goals).
- Remove leftover console.log debug statements.
Verified with pnpm lint / pnpm build, and by standing up a throwaway
Django backend (docker) with seeded data and exercising the goal
create/edit, add-cycle, and Salesforce settings flows via Playwright.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ry-merge # Conflicts: # public/i18n/en_US.json
- Remove an erroneous p-80 (320px) padding class on the CycleGoal side summary table, which was causing huge, uneven whitespace around that card. Drop the redundant duplicate p-10 alongside p-4 on the goal summary card for the same reason. - Add px-3 py-1 cell padding to the summary table so label/value columns aren't flush against each other. - Wrap the page content in the same content mx-5 my-2 container used by sibling insights pages (Program Overview, Property Insights, Default Reports) instead of leaving it unpadded/flush with the page edge. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In progress portfolio summary page
Done:
Todo: