test rewrite: legacy intg test_pam_responder.py - first batch - #9004
Open
danlavu wants to merge 2 commits into
Open
test rewrite: legacy intg test_pam_responder.py - first batch#9004danlavu wants to merge 2 commits into
danlavu wants to merge 2 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
danlavu
force-pushed
the
rewrite-test_pam_responder.py1
branch
2 times, most recently
from
July 28, 2026 19:34
5245b03 to
a4d6875
Compare
danlavu
force-pushed
the
rewrite-test_pam_responder.py1
branch
2 times, most recently
from
August 6, 2026 18:56
40157ea to
cfc5634
Compare
krishnavema
reviewed
Aug 13, 2026
| result.rc == 0 | ||
| ), f"vlock smartcard authentication failed: rc={result.rc}, stdout={result.stdout}, stderr={result.stderr}" | ||
|
|
||
| @pytest.mark.importance("medium") |
Contributor
There was a problem hiding this comment.
Hey Dan,
the five new test functions from here looks like they're accidentally nested inside test_smartcard__unlock_console_with_vlock, they just need to be dedented to module level so pytest can pick them up.
Contributor
Author
There was a problem hiding this comment.
Yes, that was a mess. I must have accidentally rebased in the wrong direction or something similar.
I also moved the vlock authentication method from the test into the framework.
danlavu
force-pushed
the
rewrite-test_pam_responder.py1
branch
6 times, most recently
from
August 13, 2026 19:08
1ad7a8d to
bfccc32
Compare
sumit-bose
reviewed
Aug 14, 2026
Port sssd/src/tests/intg/test_pam_responder.py to test_smartcard.py, test_authentication.py - test_smartcard__login_fails_when_wrong_pin_is_entered - test_smartcard__login_fails_when_card_is_not_mapped - test_smartcard__cert_auth_limited_to_allowed_pam_services - test_smartcard__login_succeeds_when_cert_auth_required - test_smartcard__login_fails_when_cert_auth_required_without_card - test_authentication__custom_password_prompt_is_shown_at_login Peeling out the reviewed test cases into it's own PR, from SSSD#8873 AI: Claude Sonnet 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
danlavu
force-pushed
the
rewrite-test_pam_responder.py1
branch
from
August 14, 2026 15:40
bfccc32 to
31951eb
Compare
sumit-bose
reviewed
Aug 18, 2026
|
|
||
|
|
||
| @pytest.mark.parametrize('simple_pam_cert_auth', ['proxy_password'], indirect=True) | ||
| def test_sc_proxy_password_fallback(simple_pam_cert_auth, env_for_sssctl): |
Contributor
There was a problem hiding this comment.
Hi,
this PR does not contain a replacement for this test.
bye,
Sumit
Contributor
There was a problem hiding this comment.
Hi,
thank you, nevertheless, can you remove the removal of the related intg tests from this PR?
bye,
Sumit
sumit-bose
reviewed
Aug 18, 2026
|
|
||
| @pytest.mark.parametrize('simple_pam_cert_auth', ['proxy_password_with_sc'], | ||
| indirect=True) | ||
| def test_sc_proxy_no_password_fallback(simple_pam_cert_auth, env_for_sssctl): |
Contributor
There was a problem hiding this comment.
Hi,
this PR does not contain a replacement for this test.
bye,
Sumit
Replace inline expect script in test_smartcard__unlock_console_with_vlock with client.auth.su.vlock_smartcard(), moving the logic into the test framework. Co-authored-by: Cursor <cursoragent@cursor.com>
danlavu
force-pushed
the
rewrite-test_pam_responder.py1
branch
from
August 19, 2026 13:42
31951eb to
4e3755e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port sssd/src/tests/intg/test_pam_responder.py to test_smartcard.py, test_authentication.py
Peeling out the reviewed test cases into it's own PR, from #8873
Depends on the following test-framework PR SSSD/sssd-test-framework#262
Model used: Claude Sonnet 4.6