Repository navigation
Link verified aircraft callsigns and make arrival updates trustworthy - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
A ticket flight such as RK1712 can broadcast an unrelated alphanumeric callsign (RUK87AL in the supplied screenshot). Prefix conversion cannot infer that association, so a journey may keep using its booking time even while a tracker shows the aircraft airborne.
Saved pickups now offer an explicit, validated, per-journey callsign link. The booking flight number and time remain unchanged; route and different-day checks still apply. Changing the link aborts superseded requests and recalculates via the existing deterministic engine. Changing the booking date clears the link. Numeric Ryanair UK designators also map RK → RUK without guessing alphanumeric aliases.
Arrival updates compare the booking and latest available estimate, show source/observation age, distinguish estimated on-stand time (including taxi) from booking arrival, and disclose stale observations. The set-off recommendation stays first. Coverage and update details are expandable; controls support keyboard/touch. No new prediction formula.
A freshly published file can no longer make an hour-old, invalid or future-dated aircraft observation usable. This closes a source-age trust gap rather than claiming each new estimate is more accurate.
Data decisions and limitations
Validation