refactor(config): Invert negative flag aria2-fallback-disabled to enabled - #6744
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. Summary by CodeRabbit
WalkthroughThe PR documents ChangesAria2 fallback configuration
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to The renamed setting appears consistent with the documented fallback behavior; no identified issue prevents merging after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 3b861cd7-3d5d-4f9a-9f09-82f810fb7171
📒 Files selected for processing (4)
CHANGELOG.mdREADME.mdlib/download.ps1libexec/scoop-config.ps1
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.
ec5c47b to
18328e5
Compare
aria2-fallback-disabled to aria2-fallback-enabledaria2-fallback-disabled to enabled
Hi @niheaven , sorry for the interruption. Whenever you have some time, I'd really appreciate it if you could take a look at this PR. I realized that the config option I added in my previous PR (#6538) was confusing and inconsistent with the earlier design. It would be best if this could be reviewed before the next release 0.6.0, while the previous option has not been released yet. For my other PRs, feel free to review and merge them if you have time; otherwise, it is totally fine to hold off until 0.6.1. |
|
Thanks for the review! |
Description
Invert negative flag
aria2-fallback-disabledto enabled. Renamearia2-fallback-disabledtoaria2-fallback-enabled.Note: The original flag was unreleased, so no deprecation or backward compatibility is required.
Motivation and Context
Scoop/README.md
Lines 85 to 86 in 880f0ae
Align with existing configuration naming conventions by using a positive flag instead of negative phrasing, avoiding double negatives and maintaining consistency across config options.
Relates to #6538
How Has This Been Tested?
Checklist:
developbranch.