Skip to content

refactor(config): Invert negative flag aria2-fallback-disabled to enabled - #6744

Merged
niheaven merged 2 commits into
ScoopInstaller:developfrom
z-Fng:invert-negative-flag
Sep 29, 2026
Merged

niheaven merged 2 commits into
ScoopInstaller:developfrom
z-Fng:invert-negative-flag

Conversation

@z-Fng

@z-Fng z-Fng commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

Invert negative flag aria2-fallback-disabled to enabled. Rename aria2-fallback-disabled to aria2-fallback-enabled.

Note: The original flag was unreleased, so no deprecation or backward compatibility is required.

Motivation and Context

Scoop/README.md

Lines 85 to 86 in 880f0ae

- aria2-enabled (default: true)
- aria2-warning-enabled (default: true)

Align with existing configuration naming conventions by using a positive flag instead of negative phrasing, avoiding double negatives and maintaining consistency across config options.

Relates to #6538

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d828f529-d13c-4426-9679-8bed1492713a

📥 Commits

Reviewing files that changed from the base of the PR and between 18328e5 and 12ea15b.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • README.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • CHANGELOG.md
  • README.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Summary by CodeRabbit

  • New Features

    • Added the aria2-fallback-enabled setting, enabled by default. When enabled or unset, downloads fall back to the default downloader after an Aria2c failure; setting it to false aborts the download instead.
  • Documentation

    • Updated aria2 configuration guidance and default-value annotations.
    • Updated the example repository URL to use HTTPS and added an issue reference to the changelog.

Walkthrough

The PR documents aria2-fallback-enabled and updates Aria2 failure handling to read ARIA2-FALLBACK-ENABLED. It also adds issue #6744 to the changelog and changes the repository example URL to HTTPS.

Changes

Aria2 fallback configuration

Layer / File(s) Summary
Fallback setting documentation
README.md, libexec/scoop-config.ps1, CHANGELOG.md
The documentation names aria2-fallback-enabled, marks it as enabled by default, and describes automatic fallback. The changelog references issue #6744. The repository example URL uses HTTPS.
Aria2 failure handling
lib/download.ps1
When ARIA2-FALLBACK-ENABLED is unset or $true, Aria2 failure handling warns and uses the default downloader. When it is $false, the download aborts.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 12ea1

The renamed setting appears consistent with the documented fallback behavior; no identified issue prevents merging after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: renaming the negative aria2-fallback-disabled flag to the positive aria2-fallback-enabled flag.
Description check ✅ Passed The description accurately explains the flag rename, naming rationale, compatibility impact, related issue, and documentation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3b861cd7-3d5d-4f9a-9f09-82f810fb7171

📥 Commits

Reviewing files that changed from the base of the PR and between 880f0ae and ec5c47b.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • README.md
  • lib/download.ps1
  • libexec/scoop-config.ps1

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Comment thread lib/download.ps1 Outdated
@z-Fng
z-Fng force-pushed the invert-negative-flag branch from ec5c47b to 18328e5 Compare September 15, 2026 22:09
@z-Fng z-Fng changed the title refactor(config): Rename aria2-fallback-disabled to aria2-fallback-enabled refactor(config): Invert negative flag aria2-fallback-disabled to enabled Sep 17, 2026
@z-Fng

z-Fng commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

Align with existing configuration naming conventions by using a positive flag instead of negative phrasing, avoiding double negatives and maintaining consistency across config options.

Invert negative flag aria2-fallback-disabled to enabled. Rename aria2-fallback-disabled to aria2-fallback-enabled.

Hi @niheaven , sorry for the interruption. Whenever you have some time, I'd really appreciate it if you could take a look at this PR. I realized that the config option I added in my previous PR (#6538) was confusing and inconsistent with the earlier design. It would be best if this could be reviewed before the next release 0.6.0, while the previous option has not been released yet.

For my other PRs, feel free to review and merge them if you have time; otherwise, it is totally fine to hold off until 0.6.1.

@niheaven
niheaven merged commit e02633c into ScoopInstaller:develop Sep 29, 2026
2 checks passed
@z-Fng

z-Fng commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review!

@z-Fng
z-Fng deleted the invert-negative-flag branch September 29, 2026 09:54
@niheaven niheaven mentioned this pull request Sep 29, 2026
2 of 3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants