Add authentication command for stripe that accepts a JWT#7935
Open
dengjeffrey wants to merge 1 commit into
Open
Add authentication command for stripe that accepts a JWT#7935dengjeffrey wants to merge 1 commit into
dengjeffrey wants to merge 1 commit into
Conversation
dengjeffrey
force-pushed
the
jd/shop-stripe-auth
branch
from
1090ba8 to
472c202
Compare
github-actions
Bot
added
the
no-changelog
dengjeffrey
force-pushed
the
jd/shop-stripe-auth
branch
from
472c202 to
4e2b9c1
Compare
dengjeffrey
force-pushed
the
jd/shop-stripe-auth
branch
from
4e2b9c1 to
84ea2cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Introduces a new command as discussed. This command will allow an agent to pass their provided signup JWT to auth into a store they are signing up for.
Works in tandem with https://github.com/shop/world/pull/845960
WHAT is this pull request doing?
process.env.SHOPIFY_STORE_AUTH_APP_CLIENT_IDas an override forSTORE_AUTH_APP_CLIENT_IDbecause local development uses a different IDHow to test your changes?
https://docs.google.com/document/d/17Jxc47OA58hH7gLBj9Cu-1x-bw0PGi4kLiAp0hsIsho/edit?tab=t.0#bookmark=id.jodpy9qjzb9j
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add