A lot of agent fixes - #462
Merged
Merged
Conversation
…etrieval and improve error handling
…proved execution flow
…on for improved execution flow
This reverts commit 19707fc.
frikky
reviewed
Aug 29, 2026
| ) | ||
|
|
||
| var project ShuffleStorage | ||
| var agentNextLLMCallMu sync.Map // Mutex to prevent duplicate parallel agent LLM runs |
Member
There was a problem hiding this comment.
Sooo, how does this work, not just in multithreaded systems, but multi-server systems?
Collaborator
Author
There was a problem hiding this comment.
Well, it won't work on a multi server system since it's stored on ram. I replaced it with cache so it works for the same purpose.
frikky
reviewed
Sep 1, 2026
| } | ||
|
|
||
| // If the execution is already FINISHED but a continuation was injected (user asked the agent to do more on top of what it already did), we need to reset the status back to EXECUTING so that HandleAiAgentExecutionStart doesn't exit with "Agent run already finished". We also persist this to cache so the guard in | ||
| lockKey := fmt.Sprintf("agent_llm_lock_%s_%s", workflowExecution.ExecutionId, originalAction.ID) |
Member
There was a problem hiding this comment.
I got a feeling the lock mechanism will cause issues.
Do we have a rerun mechanism in case we get stuck in a thread?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.