-
Notifications
You must be signed in to change notification settings - Fork 60
Implement Darcy Physics #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmegally
wants to merge
37
commits into
SimVascular:main
Choose a base branch
from
mmegally:darcy-solver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
13a64a2
Add darcy solver implementation and test case
mmegally 49c5bf6
Fix function signatures in header file
mmegally e284118
add convergence tests for darcy implementation
mmegally b1cd373
Add Regazzoni model to validate Ubuntu/macOS integration tests (added…
mmegally bae4ba1
Remove unintended SLURM files
mmegally 12e5427
Merge branch 'main' into darcy-solver
ktbolt e65e247
Addressing pull request comments (removed tests from CI suite and Zac…
mmegally 993bbc5
Addressing first set of comments from Michele (includes changing 'Phy…
mmegally d063397
fixing unit test PhysicalPropertyType dependency
mmegally 5682189
Reducing darcy coverage for 2D/3D and changing output names
mmegally dc2b9bb
Merge branch 'main' into darcy-solver
mmegally 294af52
Merge branch 'main' into darcy-solver
mmegally 68fe6ae
Removing empty NURBS block and fixing recent PhysicalPropertyType cha…
mmegally 59f6444
docs: clarify Darcy pressure and flux outputs
zasexton 6189ba6
refactor: scope Darcy material parameter names
zasexton 1d9d562
fix: validate Darcy material parameters
zasexton 99c80d1
docs: align the Darcy equation with assembly
zasexton 3344986
docs: state the Darcy single-field formulation
zasexton 5b094b4
docs: retain permeability in the diffusion operator
zasexton 7b4ca1c
docs: define Darcy model quantities and ranges
zasexton a785875
docs: document the Darcy namespace and references
zasexton 5b7d582
fix: reject embedded-line Darcy use
zasexton 8eb5ec5
refactor: clarify Darcy flux reconstruction
zasexton 71d99b2
Merge pull request #1 from zasexton/review/pr-620-michele
mmegally c83bcec
Merge branch 'main' into darcy-solver
zasexton a87e729
fix: initialize pressure using equation DOFs
zasexton 3b014e7
Merge branch 'main' into darcy-solver
zasexton 3d3d457
First set of comments: dropping element validation in inappropriate p…
mmegally e8bda34
Merge pull request #2 from zasexton/review/pr-620-comment-3887103709
mmegally a9bbd48
Renaming Darcy_media_compressibility to Darcy_compressibility & addin…
mmegally a68f7c4
Fixing instance of darcy_compressibility
mmegally 623192f
fixing incomplete removal of runtime error call from std namespace
mmegally c159793
fixing svmp exception calls
mmegally d9c4cc8
L2 projection and volume-weighted flux.
zasexton 28f48ec
Merge pull request #3 from zasexton/review/pr-620-latest
mmegally 3125479
Merge branch 'main' into darcy-solver
zasexton ae99df4
dropping context tag
mmegally File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.