Add option to select activation function for ChamberSphere - #239
Conversation
…y of activation funcitons. Added double_tanh activation funciton to activation function file. Changed chamver_sphere.json test case to be able to choose activaiton function. when double_tanh activation funciton was selected test case runs as previously ran.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
@charoheijnen, it looks like the GUI test is throwing an error:
I think the fix is to bump this up to 24 (or avoid setting a version altogether): svZeroDSolver/.github/workflows/gui.yml Line 22 in ce68a7c |
mrp089
left a comment
mrp089
left a comment
There was a problem hiding this comment.
Great work, @charoheijnen! See below two comments
mrp089
left a comment
mrp089
left a comment
There was a problem hiding this comment.
I think SimulationParameters can be simplified. See comments.
(Result files only change in order not in actual values!)
|
A bigger overhaul due to the changes in the main repo that had happened in the meantime, which had quite an impact on the changes that had previously been made in this pull request. Ready for re-review (the test files have only changed in order, due to reclassification of ChamberSphere as a chamber not a vessel, not in values!) |
|
Thank you! Can you have a look at my two remaining comments? |
…(moved back) and extra check was not necessary, so removed
|
Now all comments should be fully addressed! I also implemented the has_activation_function flag, from the first comment. |
|
Is |
|
There are none currently that don't use an activation function, I don't know if it would ever come to the point that we want to implement one without activation function (i.e. a different kind of activation mechanism)? |
|
I can revert that change and leave it so that it is required for any chamber to have an activation function |
|
I think it's reasonable to assume every chamber will have an activation function for now |
This reverts commit e2da096.
mrp089
left a comment
mrp089
left a comment
There was a problem hiding this comment.
Thank you, @charoheijnen and @KatrinKoesler!
3 participants
Add option to select activation function for ChamberSphere
Current situation
Currently activation function is hard coded within ChamberSphere. As detailed in #236
Release Notes
Testing
Code of Conduct & Contributing Guidelines