[3.0] Theme split (wave 8, part 4) — clear floats with inline-start and inline-end - #9571
Merged
jdarwood007 merged 1 commit intoSep 6, 2026
Conversation
This was referenced Aug 29, 2026
Closed
albertlast
force-pushed
the
3.0/theme-rtl-clear
branch
2 times, most recently
from
September 2, 2026 07:12
15271bf to
42800fc
Compare
albertlast
force-pushed
the
3.0/theme-rtl-clear
branch
from
September 6, 2026 00:11
42800fc to
43e2c99
Compare
clear: inline-start and clear: inline-end follow the writing direction, so the three places where rtl.css only mirrored the side no longer need an override. clear: both is unaffected and untouched. One group is deliberately left alone. index.css clears .signature, .attachments, .under_message, .custom_fields_above_signature and .custom_fields_below_signature together, but rtl.css mirrors only the first, second and fourth of those. Converting the group would start mirroring .under_message and .custom_fields_below_signature as well, which is a change in behaviour rather than a no-op, so the group keeps its physical value. Whether the two missing from rtl.css are an oversight is worth deciding separately - all three appear in the markup, so it is not a question about dead code. Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
albertlast
force-pushed
the
3.0/theme-rtl-clear
branch
from
September 6, 2026 08:49
43e2c99 to
1b661ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 4 of wave 8 of the #7933 split.
clear: inline-startandclear: inline-endfollow the writing direction, so the threeplaces where
rtl.cssdid nothing but mirror the side no longer need an override.clear: bothis unaffected and untouched.The one group left alone, and why
index.cssclears five selectors together —.signature,.attachments,.under_message,.custom_fields_above_signatureand.custom_fields_below_signature—but
rtl.cssmirrors only three of them. Converting the group would also start mirroring.under_messageand.custom_fields_below_signature, which is a behaviour change, nota no-op, so the group keeps its physical value here.
Whether those two are missing from
rtl.cssby accident is worth deciding on its own.It is not a question about dead code — all three of the classes involved are emitted by
the templates, so the asymmetry is real and visible in a right-to-left language.
How this was checked
Same method as parts 2 and 3, on 29 pages captured back to back across a stash.
One addition worth noting: a poll had to be posted and voted on first. The
#poll_options dl.options dtrule is one of the three being converted, and none of theexisting sweep pages reached it — the results list only renders once a vote has been cast,
so before that the check would have passed without ever exercising the rule. With the poll
in place the sweep covers all three.
clearkeywordclearkeywordNo geometry moved in either direction.
rtl.cssgoes from 453 lines to 442.Issues References (Fixes|Related|Closes)
Related to #7933.
On the ordering of these four
These were originally stacked. They are not any more — each of #9569, #9570, #9571 and
#9572 now branches from
release-3.0on its own and contains exactly one commit, so eachdiff shows only its own property and nothing else. They can be reviewed in any order.
They cannot all be merged without a rebase in between, and that is worth being straight
about. One
rtl.cssrule usually mirrors several properties at once, so these PRs editsome of the same declaration blocks.
release-3.0has:#9569 removes both
floats, #9570 removes thetext-align, #9571 removes theclear—and a rule only disappears once its last declaration is gone. Merging any one of these is
fine; after that I will rebase the rest, which is a few minutes of work each time. Of the
six pairs,
text-align+clearandclear+margins merge cleanly as they stand; thefloatone overlaps with all three, so merging that one first costs the least.