Skip to content

[3.0] Theme split (wave 8, part 4) — clear floats with inline-start and inline-end - #9571

Merged
jdarwood007 merged 1 commit into
SimpleMachines:release-3.0from
albertlast:3.0/theme-rtl-clear
Sep 6, 2026
Merged

[3.0] Theme split (wave 8, part 4) — clear floats with inline-start and inline-end#9571
jdarwood007 merged 1 commit into
SimpleMachines:release-3.0from
albertlast:3.0/theme-rtl-clear

Conversation

@albertlast

@albertlast albertlast commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Part 4 of wave 8 of the #7933 split.

clear: inline-start and clear: inline-end follow the writing direction, so the three
places where rtl.css did nothing but mirror the side no longer need an override.
clear: both is unaffected and untouched.

The one group left alone, and why

index.css clears five selectors together — .signature, .attachments,
.under_message, .custom_fields_above_signature and .custom_fields_below_signature
but rtl.css mirrors only three of them. Converting the group would also start mirroring
.under_message and .custom_fields_below_signature, which is a behaviour change, not
a no-op
, so the group keeps its physical value here.

Whether those two are missing from rtl.css by accident is worth deciding on its own.
It is not a question about dead code — all three of the classes involved are emitted by
the templates, so the asymmetry is real and visible in a right-to-left language.

How this was checked

Same method as parts 2 and 3, on 29 pages captured back to back across a stash.

One addition worth noting: a poll had to be posted and voted on first. The
#poll_options dl.options dt rule is one of the three being converted, and none of the
existing sweep pages reached it — the results list only renders once a vote has been cast,
so before that the check would have passed without ever exercising the rule. With the poll
in place the sweep covers all three.

elements differences
left-to-right 9735 5, all the clear keyword
right-to-left 9735 5, all the clear keyword

No geometry moved in either direction.

rtl.css goes from 453 lines to 442.

Issues References (Fixes|Related|Closes)

Related to #7933.


On the ordering of these four

These were originally stacked. They are not any more — each of #9569, #9570, #9571 and
#9572 now branches from release-3.0 on its own and contains exactly one commit, so each
diff shows only its own property and nothing else. They can be reviewed in any order.

They cannot all be merged without a rebase in between, and that is worth being straight
about. One rtl.css rule usually mirrors several properties at once, so these PRs edit
some of the same declaration blocks. release-3.0 has:

#poll_options dl.options dt { float: right; clear: right; }
#poll_options dl.options dd { float: right; text-align: left; }

#9569 removes both floats, #9570 removes the text-align, #9571 removes the clear
and a rule only disappears once its last declaration is gone. Merging any one of these is
fine; after that I will rebase the rest, which is a few minutes of work each time. Of the
six pairs, text-align+clear and clear+margins merge cleanly as they stand; the
float one overlaps with all three, so merging that one first costs the least.

clear: inline-start and clear: inline-end follow the writing direction, so the
three places where rtl.css only mirrored the side no longer need an override.
clear: both is unaffected and untouched.

One group is deliberately left alone. index.css clears .signature,
.attachments, .under_message, .custom_fields_above_signature and
.custom_fields_below_signature together, but rtl.css mirrors only the first,
second and fourth of those. Converting the group would start mirroring
.under_message and .custom_fields_below_signature as well, which is a change in
behaviour rather than a no-op, so the group keeps its physical value. Whether
the two missing from rtl.css are an oversight is worth deciding separately -
all three appear in the markup, so it is not a question about dead code.

Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
@jdarwood007
jdarwood007 merged commit c6a782f into SimpleMachines:release-3.0 Sep 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants