Skip to content

[3.0] Theme split (wave 9, part 1) — lay settings lists out on a grid rather than with floats #9662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdarwood007 merged 1 commit into from
Sep 8, 2026
Merged

[3.0] Theme split (wave 9, part 1) — lay settings lists out on a grid rather than with floats #9662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions Themes/default/css/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,26 +725,25 @@ a.moderation_link, a.moderation_link:visited {
------------------------------------------------------- */
dl.settings {
clear: inline-end;
overflow: auto;
display: grid;
grid-template-columns: 1fr 1fr;
align-items: start;
gap: 6px 0;
margin: 0 0 10px 0;
padding: 5px;
}
dl.settings dt {
width: 56%;
float: inline-start;
margin: 0 0 10px 0;
clear: both;
grid-column: 1;
}
/* A label that carries its own background stands on its own line, so it takes
the whole row rather than the label column. */
dl.settings dt.windowbg {
width: 98%;
float: inline-start;
grid-column: 1 / -1;
margin: 0 0 3px 0;
padding: 0 0 5px 0;
clear: both;
}
dl.settings dd {
width: 42%;
float: inline-end;
grid-column: 2;
margin: 0 0 3px 0;
}
dl.settings img {
Expand Down
3 changes: 3 additions & 0 deletions Themes/default/css/maintenance.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ dl.settings.adminlogin dd {
order: 0;
margin-top: 2em;
}
dl.settings {
grid-template-columns: 1fr;
}
dl.settings dd {
-ms-grid-column: 1;
grid-column: 1;
Expand Down
8 changes: 8 additions & 0 deletions Themes/default/css/responsive.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,14 @@
width: 100%;
float: none;
}
/* Settings lists are a two column grid on wider screens. Here there is no
room for a second column, so the whole row is one. */
dl.settings {
grid-template-columns: 1fr;
}
dl.settings dt, dl.settings dd {
grid-column: 1;
}
#post_draft_options dl.settings dt, #post_draft_options dl.settings dd {
width: 50%;
float: left;
Expand Down