Add make_kron binding for the native kron atom#19
Merged
Conversation
Expose new_kron via make_kron(param_capsule, child_capsule, const_is_left, p, q, r, s): the variable-free operand is the parameter side, const_is_left selects which operand it is, and (p, q)/(r, s) are A's/B's dims. Replaces the orphaned kron.h stub (which referenced a nonexistent new_kron_identity and was never wired into bindings.c). Bumps the SparseDiffEngine submodule to the kron-native-atom commit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Follows the engine's sparse-only kron rework: the caller passes the variable-free operand's active (nonzero) column-major block indices so only those output rows are materialized. Bumps the SparseDiffEngine submodule to the sparse kron + output-driven matmul sparsity commits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…e key The submodule now points at the squash-merged kron atom on engine main (SparseDifferentiation/SparseDiffEngine#101). cmake.minimum-version was deprecated by scikit-build-core in favor of cmake.version. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose new_kron via make_kron(param_capsule, child_capsule, const_is_left, p, q, r, s): the variable-free operand is the parameter side, const_is_left selects which operand it is, and (p, q)/(r, s) are A's/B's dims. Replaces the orphaned kron.h stub (which referenced a nonexistent new_kron_identity and was never wired into bindings.c). Bumps the SparseDiffEngine submodule to the kron-native-atom commit.